Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft version for V2 of AzureCloudPowerShellDeployment #18165

Merged
merged 40 commits into from
May 10, 2023
Merged

Draft version for V2 of AzureCloudPowerShellDeployment #18165

merged 40 commits into from
May 10, 2023

Conversation

onetocny
Copy link
Contributor

@onetocny onetocny commented Apr 24, 2023 •
edited
Loading

Task name: AzureCloudPowerShellDeploymentV2

Description: Support WIF in AzureCloudPowerShellDeployment task

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@onetocny
Copy link
Contributor Author

onetocny commented Apr 24, 2023 •
edited
Loading

I have found following issues so far:

  • Tasks ends up with warning in cases when it should fail (e.g. required input is missing) thus whole CI pipeline looks like everything is passing.
  • Some required inputs were newly introduced (e.g. key vault, csdef file). Are they really required (it was not in previous version)? This is a potential complication for transition from V1 to V2 (as well as from secret based connections to WIF).
  • New-AzCloudService internally creates other resources such as records in blob storage or public IP address. In case that such resources already exists cmdlet is trying to interactively ask if the existing resources should be overwritten. At this point it fails as whole task is running in non-interactive mode.

image

@starkmsu fyi

onetocny and others added 15 commits April 24, 2023 17:17
@onetocny
Merge branch "master" into users/snesterov/acpsd-v2
6fc01d7
@starkmsu
Merge branch "master" into users/snesterov/acpsd-v2
333e9b7
@onetocny
Merge branch "master" into users/snesterov/acpsd-v2
2bafaad
@ozanMSFT
- test log is added
8cbfe9f
@ozanMSFT
- missing parameters are added
bd4f422
@ozanMSFT
- typo fix
7c1fd42
@onetocny
Merge branch "master" into users/snesterov/acpsd-v2
4a33c89
@onetocny
Merge branch "master" into users/snesterov/acpsd-v2
927599f
@starkmsu
Deleted command to set policy since service principle might not have …
25fe17c 
…permissions to set it
@starkmsu
Tried to apply the hack with default params
4a6da55
@starkmsu
Added blob file removal before service creation
86a8e71
@starkmsu
Added azStorageContext for Remove-AzStorageBlob command
a7de8a4
@starkmsu
Merge branch "master" into users/snesterov/acpsd-v2
8a6c2b9
@starkmsu
Added public ip cleanup for Create-AzureCloudService call
e7db179
@starkmsu
Merge branch "master" into users/snesterov/acpsd-v2
b52099b
@starkmsu
Copy link
Contributor

starkmsu commented May 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@starkmsu
Copy link
Contributor

starkmsu commented May 4, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@starkmsu
Copy link
Contributor

starkmsu commented May 4, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@starkmsu
Copy link
Contributor

starkmsu commented May 4, 2023

/azp run

1 similar comment
@starkmsu
Copy link
Contributor

starkmsu commented May 4, 2023

/azp run

@starkmsu
Copy link
Contributor

starkmsu commented May 5, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@starkmsu starkmsu marked this pull request as ready for review May 5, 2023 10:40
@starkmsu
Copy link
Contributor

starkmsu commented May 5, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@starkmsu starkmsu marked this pull request as draft May 8, 2023 09:27
@starkmsu starkmsu marked this pull request as ready for review May 9, 2023 15:52
@starkmsu starkmsu requested a review from rvairavelu as a code owner May 9, 2023 15:52
@starkmsu starkmsu merged commit 7cb943c into master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manolerazvan manolerazvan manolerazvan approved these changes

@rvairavelu rvairavelu Awaiting requested review from rvairavelu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onetocny @starkmsu @manolerazvan @ozanMSFT