Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a simplified version of Conda Authenticate #18115

Merged

Conversation

amp-powell
Copy link
Contributor

@amp-powell amp-powell commented Apr 14, 2023

Task name: CondaAuthenticate

Description: Conda auth that just authenticates the token "ARTIFACTS_CONDA_TOKEN" when it is used in the channels_alias property

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) N

Attached related issue: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@amp-powell amp-powell requested review from a team as code owners April 14, 2023 20:46
Tasks/NpmAuthenticateV0/package-lock.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Tasks/CondaAuthenticateV0/package.json Outdated Show resolved Hide resolved
Tasks/CondaAuthenticateV0/task.json Outdated Show resolved Hide resolved
Tasks/CondaAuthenticateV0/constants.ts Outdated Show resolved Hide resolved
Tasks/AndroidSigningV3/Tests/package-lock.json Outdated Show resolved Hide resolved
Tasks/AndroidSigningV2/package-lock.json Outdated Show resolved Hide resolved
Tasks/AndroidSigningV2/Tests/package-lock.json Outdated Show resolved Hide resolved
Tasks/ANTV1/package-lock.json Outdated Show resolved Hide resolved
Tasks/ANTV1/Tests/package-lock.json Outdated Show resolved Hide resolved
@zhenghao104
Copy link
Contributor

There are still some files from other tasks that you should revert.

Copy link
Contributor

@zhenghao104 zhenghao104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert files from non cargo tasks

@zhenghao104
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@amp-powell amp-powell force-pushed the abpowell/simplified-conda-authenticate-v0 branch from ea396b6 to 17bb8be Compare April 20, 2023 21:48
@amp-powell
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 18115 in repo microsoft/azure-pipelines-tasks

@zhenghao104
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@amp-powell
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 18115 in repo microsoft/azure-pipelines-tasks

@jmyersmsft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@zhenghao104
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@zhenghao104
Copy link
Contributor

"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 221,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to 220, we will deploy this task with the current sprint to expedite the rollout

@zhenghao104
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@zhenghao104
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@amp-powell amp-powell merged commit 41b2c13 into microsoft:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants