Fix accidental relative imports from non namespace barrels #59544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
approved these changes
Aug 7, 2024
sheetalkamat
approved these changes
Aug 7, 2024
|
Yeah, I'll write a lint rule quick that prevents this; given it seems like we can actually do direct imports, but only in some project, we'd need that lint rule anyway, just applied to a different set of packages. |
sheetalkamat
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #59542; no file in our codebase should be bypassing the namespace barrels except those in
src/compiler(in rare cases) or test code.The only reason things didn't break is because these imports were done within services, which is only ever consumed by other entrypoints; if this had been done from say,
tsserver, the magic import rewriting done in our build would have caused "double bundling" where we'd include the same code twice.However, the fact that it did work implies that we could get away with direct imports except in our entrypoints, which is great because I thought I had unintentionally made direct imports impossible by making our package smaller. Turns out, no, we still can do it for anything without that magic build step.