Don"t treat an instantiation expression as an assertion in skipOuterExpressions #59538

jakebailey · 2024-08-05T20:41:42Z

#50820 added ExpressionWithTypeArguments to isOuterExpression but treated it as an assertion, which then caused the checker to skip past it in reference checking. Split that out so we can skip past it in transforms like we did previously, which feels better because an instantiation is not really an assertion.

Also, while here, fix the fact that other OuterExpression related code was not ExpressionWithTypeArguments either.

Fixes #59535

…xpressions

jakebailey · 2024-08-05T20:41:49Z

@typescript-bot test it

typescript-bot · 2024-08-05T20:41:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-05T20:41:57Z

Looks like you"re introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki"s API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

typescript-bot · 2024-08-05T21:03:54Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-05T21:08:07Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59538/merge:

Everything looks good!

typescript-bot · 2024-08-05T21:19:10Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,921k (± 0.75%)}	_{194,723k (± 0.95%)}	_{+1,803k (+ 0.93%)}	_192,332k	_195,939k	_{p=0.030 n=6}
_{Parse Time}	_{1.31s (± 0.39%)}	_{1.30s (± 0.90%)}	_~	_1.28s	_1.31s	_{p=0.523 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.55s (± 0.27%)}	_{9.56s (± 0.45%)}	_~	_9.50s	_9.61s	_{p=0.629 n=6}
_{Emit Time}	_{2.74s (± 0.79%)}	_{2.74s (± 0.71%)}	_~	_2.71s	_2.76s	_{p=0.746 n=6}
_{Total Time}	_{14.31s (± 0.19%)}	_{14.31s (± 0.44%)}	_~	_14.23s	_14.38s	_{p=0.688 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,537	_945,537	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,512	_409,512	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,254k (± 0.00%)}	_{1,222,290k (± 0.00%)}	_~	_1,222,213k	_1,222,350k	_{p=0.173 n=6}
_{Parse Time}	_{6.61s (± 0.53%)}	_{6.61s (± 0.56%)}	_~	_6.57s	_6.66s	_{p=0.808 n=6}
_{Bind Time}	_{1.86s (± 0.28%)}	_{1.86s (± 0.53%)}	_~	_1.84s	_1.87s	_{p=0.386 n=6}
_{Check Time}	_{31.19s (± 0.23%)}	_{31.14s (± 0.38%)}	_~	_30.94s	_31.26s	_{p=0.521 n=6}
_{Emit Time}	_{15.01s (± 0.50%)}	_{14.97s (± 0.41%)}	_~	_14.90s	_15.06s	_{p=0.470 n=6}
_{Total Time}	_{54.67s (± 0.30%)}	_{54.58s (± 0.29%)}	_~	_54.33s	_54.77s	_{p=0.521 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,486,257	_2,486,257	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,013,836	_1,013,836	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,492,109k (± 0.00%)}	_{2,492,136k (± 0.01%)}	_~	_2,492,022k	_2,492,492k	_{p=0.575 n=6}
_{Parse Time}	_{9.20s (± 0.42%)}	_{9.18s (± 0.21%)}	_~	_9.16s	_9.21s	_{p=0.870 n=6}
_{Bind Time}	_{2.19s (± 0.56%)}	_{2.20s (± 0.23%)}	_~	_2.20s	_2.21s	_{p=0.051 n=6}
_{Check Time}	_{75.56s (± 0.48%)}	_{75.23s (± 0.39%)}	_~	_74.86s	_75.67s	_{p=0.092 n=6}
_{Emit Time}	_{0.28s (± 3.19%)}	_{0.29s (± 1.80%)}	_~	_0.28s	_0.29s	_{p=0.190 n=6}
_{Total Time}	_{87.23s (± 0.39%)}	_{86.90s (± 0.36%)}	_~	_86.51s	_87.37s	_{p=0.173 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,171	_1,229,232	_{+61 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,285	_264,398	_{+113 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,349,341k (± 0.03%)}	_{2,349,956k (± 0.02%)}	_~	_2,348,985k	_2,350,498k	_{p=0.093 n=6}
_{Parse Time}	_{4.99s (± 1.48%)}	_{4.98s (± 0.55%)}	_~	_4.94s	_5.01s	_{p=0.630 n=6}
_{Bind Time}	_{1.88s (± 0.34%)}	_{1.89s (± 0.97%)}	_~	_1.86s	_1.91s	_{p=0.346 n=6}
_{Check Time}	_{34.45s (± 0.39%)}	_{34.42s (± 0.41%)}	_~	_34.19s	_34.56s	_{p=0.810 n=6}
_{Emit Time}	_{3.31s (± 0.55%)}	_{3.30s (± 0.92%)}	_~	_3.26s	_3.35s	_{p=0.419 n=6}
_{Total Time}	_{44.65s (± 0.48%)}	_{44.59s (± 0.29%)}	_~	_44.40s	_44.76s	_{p=1.000 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,171	_1,229,232	_{+61 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,285	_264,398	_{+113 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,422,597k (± 0.02%)}	_{2,422,937k (± 0.02%)}	_~	_2,422,359k	_2,423,491k	_{p=0.378 n=6}
_{Parse Time}	_{6.21s (± 1.26%)}	_{6.24s (± 0.71%)}	_~	_6.19s	_6.31s	_{p=0.521 n=6}
_{Bind Time}	_{2.02s (± 0.31%)}	_{2.02s (± 0.66%)}	_~	_2.01s	_2.04s	_{p=0.366 n=6}
_{Check Time}	_{41.12s (± 0.46%)}	_{40.98s (± 0.27%)}	_~	_40.86s	_41.15s	_{p=0.126 n=6}
_{Emit Time}	_{4.08s (± 3.85%)}	_{4.05s (± 2.53%)}	_~	_3.98s	_4.25s	_{p=0.810 n=6}
_{Total Time}	_{53.46s (± 0.53%)}	_{53.30s (± 0.35%)}	_~	_53.14s	_53.67s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,238	_256,285	_{+47 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,976	_105,053	_{+77 (+ 0.07%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,308k (± 0.04%)}	_{428,352k (± 0.02%)}	_~	_428,287k	_428,550k	_{p=0.173 n=6}
_{Parse Time}	_{4.14s (± 0.33%)}	_{4.13s (± 0.29%)}	_~	_4.12s	_4.15s	_{p=0.137 n=6}
_{Bind Time}	_{1.60s (± 0.97%)}	_{1.62s (± 1.35%)}	_~	_1.58s	_1.64s	_{p=0.103 n=6}
_{Check Time}	_{22.20s (± 0.30%)}	_{22.25s (± 0.36%)}	_~	_22.12s	_22.34s	_{p=0.173 n=6}
_{Emit Time}	_{2.02s (± 1.41%)}	_{2.02s (± 0.94%)}	_~	_1.99s	_2.05s	_{p=0.624 n=6}
_{Total Time}	_{29.96s (± 0.21%)}	_{30.02s (± 0.28%)}	_~	_29.86s	_30.10s	_{p=0.173 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,105k (± 0.04%)}	_{370,140k (± 0.02%)}	_~	_369,962k	_370,190k	_{p=0.689 n=6}
_{Parse Time}	_{3.46s (± 0.72%)}	_{3.43s (± 0.81%)}	_~	_3.39s	_3.46s	_{p=0.226 n=6}
_{Bind Time}	_{1.92s (± 1.18%)}	_{1.91s (± 0.21%)}	_~	_1.90s	_1.91s	_{p=1.000 n=6}
_{Check Time}	_{19.36s (± 0.32%)}	_{19.33s (± 0.38%)}	_~	_19.26s	_19.47s	_{p=0.375 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.73s (± 0.22%)}	_{24.68s (± 0.36%)}	_~	_24.59s	_24.84s	_{p=0.172 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,992,449	_2,992,449	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,029,577	_1,029,577	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,117,177k (± 0.00%)}	_{3,117,150k (± 0.00%)}	_~	_3,117,034k	_3,117,274k	_{p=0.810 n=6}
_{Parse Time}	_{13.82s (± 0.53%)}	_{13.87s (± 0.58%)}	_~	_13.79s	_14.02s	_{p=0.297 n=6}
_{Bind Time}	_{4.34s (± 2.21%)}	_{4.34s (± 1.95%)}	_~	_4.29s	_4.51s	_{p=0.806 n=6}
_{Check Time}	_{79.48s (± 0.56%)}	_{79.55s (± 0.36%)}	_~	_79.20s	_79.92s	_{p=0.688 n=6}
_{Emit Time}	_{20.54s (± 0.68%)}	_{20.53s (± 0.62%)}	_~	_20.35s	_20.73s	_{p=0.873 n=6}
_{Total Time}	_{118.17s (± 0.57%)}	_{118.29s (± 0.17%)}	_~	_118.03s	_118.56s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_268,291	_268,291	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,194	_109,194	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{413,130k (± 0.01%)}	_{413,119k (± 0.02%)}	_~	_413,072k	_413,248k	_{p=0.471 n=6}
_{Parse Time}	_{3.83s (± 0.51%)}	_{3.81s (± 0.52%)}	_~	_3.80s	_3.85s	_{p=0.143 n=6}
_{Bind Time}	_{1.72s (± 0.60%)}	_{1.72s (± 0.44%)}	_~	_1.71s	_1.73s	_{p=0.931 n=6}
_{Check Time}	_{16.80s (± 0.35%)}	_{16.78s (± 0.21%)}	_~	_16.74s	_16.83s	_{p=0.628 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.34s (± 0.23%)}	_{22.31s (± 0.16%)}	_~	_22.25s	_22.36s	_{p=0.332 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,548	_538,548	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,473	_176,473	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{481,356k (± 0.01%)}	_{481,338k (± 0.02%)}	_~	_481,272k	_481,479k	_{p=0.261 n=6}
_{Parse Time}	_{3.39s (± 0.73%)}	_{3.40s (± 0.47%)}	_~	_3.37s	_3.41s	_{p=0.331 n=6}
_{Bind Time}	_{1.25s (± 0.44%)}	_{1.25s (± 1.01%)}	_~	_1.23s	_1.26s	_{p=0.663 n=6}
_{Check Time}	_{17.99s (± 0.36%)}	_{17.96s (± 0.42%)}	_~	_17.82s	_18.03s	_{p=0.574 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.63s (± 0.24%)}	_{22.61s (± 0.29%)}	_~	_22.49s	_22.68s	_{p=0.470 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-05T22:23:47Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59538/merge:

Everything looks good!

jakebailey · 2024-08-06T15:19:43Z

src/compiler/factory/nodeFactory.ts

+            case SyntaxKind.ExpressionWithTypeArguments:
+                return updateExpressionWithTypeArguments(outerExpression, expression, outerExpression.typeArguments);


I will note that most of the cases here are uncovered by tests:

jakebailey added 3 commits August 5, 2024 13:06

Test

e5bec98

Don"t treat an instantiation expression as an assertion in skipOuterE…

e86c19b

…xpressions

Fix the types I think

a5cf7db

jakebailey requested a review from rbuckton August 5, 2024 20:41

typescript-bot assigned jakebailey Aug 5, 2024

typescript-bot added the Author: Team label Aug 5, 2024

typescript-bot assigned DanielRosenwasser and rbuckton Aug 5, 2024

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 5, 2024

typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 5, 2024

jakebailey added 2 commits August 5, 2024 13:42

fmt

ae6806b

I"m sick of shifting this random other bit around

bbe4b61

jakebailey commented Aug 6, 2024

View reviewed changes

jakebailey requested review from weswigham and RyanCavanaugh August 6, 2024 18:14

weswigham approved these changes Aug 6, 2024

View reviewed changes

jakebailey merged commit 9987812 into microsoft:main Aug 6, 2024
32 checks passed

jakebailey deleted the fix-59535 branch August 6, 2024 22:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don"t treat an instantiation expression as an assertion in skipOuterExpressions #59538

Don"t treat an instantiation expression as an assertion in skipOuterExpressions #59538

jakebailey commented Aug 5, 2024 •

edited

Loading

jakebailey commented Aug 5, 2024

typescript-bot commented Aug 5, 2024 •

edited

Loading

typescript-bot commented Aug 5, 2024

typescript-bot commented Aug 5, 2024

typescript-bot commented Aug 5, 2024

typescript-bot commented Aug 5, 2024

tsc

typescript-bot commented Aug 5, 2024

jakebailey Aug 6, 2024

		case SyntaxKind.ExpressionWithTypeArguments:
		return updateExpressionWithTypeArguments(outerExpression, expression, outerExpression.typeArguments);

Don"t treat an instantiation expression as an assertion in skipOuterExpressions #59538

Don"t treat an instantiation expression as an assertion in skipOuterExpressions #59538

Conversation

jakebailey commented Aug 5, 2024 • edited Loading

jakebailey commented Aug 5, 2024

typescript-bot commented Aug 5, 2024 • edited Loading

typescript-bot commented Aug 5, 2024

typescript-bot commented Aug 5, 2024

typescript-bot commented Aug 5, 2024

typescript-bot commented Aug 5, 2024

tsc

typescript-bot commented Aug 5, 2024

jakebailey Aug 6, 2024

Choose a reason for hiding this comment

jakebailey commented Aug 5, 2024 •

edited

Loading

typescript-bot commented Aug 5, 2024 •

edited

Loading