Dont filter type aquisition when its not enabled #59351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps getting auto type directives if they wont be needed
typescript-bot
added
Author: Team
For Uncommitted Bug
1 task
jakebailey
reviewed
Jul 18, 2024
| @@ -1627,6 1627,7 @@ export abstract class Project implements LanguageServiceHost, ModuleResolutionHo | |||
| } | |||
|
|
|||
| protected removeExistingTypings(include: string[]): string[] { | |||
| if (!include.length) return include; | |||
There was a problem hiding this comment.
Should this return a copy? Or is it fine to share?
There was a problem hiding this comment.
Not needed since the array is just used to set the value as new include option in type aquisition.
I am wondering if i should make this private .. not idea why this was protected.
There was a problem hiding this comment.
Could it just be readonly string[] at that point? (But, fine as-is)
There was a problem hiding this comment.
it wont match the TypeAcquisitions input property and thats why i left it like that.
jakebailey
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps getting auto type directives if they wont be needed
Helps with #59338