Don't skip markLinkedReferences on ambient properties #59325

jakebailey · 2024-07-17T17:20:27Z

Alternatively, I can also only walk ambients when emitDecoratorMetadata is on, or only when the hint is Unspecified or Decorator.

jakebailey · 2024-07-17T17:20:38Z

@typescript-bot test it

typescript-bot · 2024-07-17T17:20:42Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-17T17:41:09Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-17T17:46:19Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59325/merge:

Everything looks good!

typescript-bot · 2024-07-17T18:04:42Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,103k (± 0.97%)}	_{194,135k (± 0.98%)}	_~	_192,247k	_195,931k	_{p=1.000 n=6}
_{Parse Time}	_{1.30s (± 1.71%)}	_{1.31s (± 0.75%)}	_~	_1.29s	_1.32s	_{p=0.655 n=6}
_{Bind Time}	_{0.71s (± 0.57%)}	_0.71s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.51s (± 0.22%)}	_{9.53s (± 0.50%)}	_~	_9.47s	_9.60s	_{p=0.422 n=6}
_{Emit Time}	_{2.73s (± 1.26%)}	_{2.73s (± 1.59%)}	_~	_2.65s	_2.77s	_{p=0.935 n=6}
_{Total Time}	_{14.25s (± 0.34%)}	_{14.28s (± 0.18%)}	_~	_14.25s	_14.32s	_{p=0.224 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,120	_944,120	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,047	_407,047	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,670k (± 0.00%)}	_{1,218,649k (± 0.00%)}	_~	_1,218,603k	_1,218,703k	_{p=0.471 n=6}
_{Parse Time}	_{6.72s (± 0.60%)}	_{6.68s (± 0.73%)}	_~	_6.60s	_6.73s	_{p=0.376 n=6}
_{Bind Time}	_{1.86s (± 0.79%)}	_{1.87s (± 0.73%)}	_~	_1.85s	_1.88s	_{p=0.672 n=6}
_{Check Time}	_{31.03s (± 0.44%)}	_{30.96s (± 0.35%)}	_~	_30.80s	_31.10s	_{p=0.471 n=6}
_{Emit Time}	_{15.02s (± 0.71%)}	_{15.00s (± 0.33%)}	_~	_14.92s	_15.07s	_{p=1.000 n=6}
_{Total Time}	_{54.63s (± 0.34%)}	_{54.52s (± 0.25%)}	_~	_54.40s	_54.74s	_{p=0.261 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,275,944	_2,275,944	_~	_~	_~	_{p=1.000 n=6}
_Types	_948,749	_948,749	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,207,308k (± 0.00%)}	_{2,207,244k (± 0.00%)}	_~	_2,207,134k	_2,207,337k	_{p=0.173 n=6}
_{Parse Time}	_{9.69s (± 0.27%)}	_{9.68s (± 0.28%)}	_~	_9.65s	_9.73s	_{p=0.515 n=6}
_{Bind Time}	_{3.39s (± 0.91%)}	_{3.37s (± 0.35%)}	_~	_3.35s	_3.38s	_{p=0.072 n=6}
_{Check Time}	_{105.46s (± 0.52%)}	_{105.78s (± 0.39%)}	_~	_105.20s	_106.24s	_{p=0.298 n=6}
_{Emit Time}	_{0.20s (± 2.06%)}	_{0.20s (± 4.47%)}	_~	_0.19s	_0.21s	_{p=0.787 n=6}
_{Total Time}	_{118.76s (± 0.48%)}	_{119.04s (± 0.35%)}	_~	_118.46s	_119.54s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,101	_1,227,101	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,800	_261,800	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,459,002k (±11.76%)}	_{2,340,826k (± 0.03%)}	_~	_2,339,530k	_2,341,579k	_{p=1.000 n=6}
_{Parse Time}	_{5.13s (± 0.93%)}	_{5.12s (± 0.49%)}	_~	_5.07s	_5.14s	_{p=1.000 n=6}
_{Bind Time}	_{1.89s (± 0.78%)}	_{1.90s (± 0.67%)}	_~	_1.88s	_1.92s	_{p=0.392 n=6}
_{Check Time}	_{34.47s (± 0.52%)}	_{34.41s (± 0.29%)}	_~	_34.25s	_34.55s	_{p=1.000 n=6}
_{Emit Time}	_{3.34s (± 1.64%)}	_{3.29s (± 1.54%)}	_~	_3.21s	_3.36s	_{p=0.230 n=6}
_{Total Time}	_{44.84s (± 0.50%)}	_{44.74s (± 0.30%)}	_~	_44.55s	_44.90s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,101	_1,227,101	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,800	_261,800	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,415,560k (± 0.02%)}	_{2,415,143k (± 0.01%)}	_~	_2,414,890k	_2,415,531k	_{p=0.229 n=6}
_{Parse Time}	_{5.29s (± 1.09%)}	_{5.25s (± 0.43%)}	_~	_5.21s	_5.28s	_{p=0.229 n=6}
_{Bind Time}	_{1.70s (± 0.81%)}	_{1.70s (± 0.48%)}	_~	_1.69s	_1.71s	_{p=0.868 n=6}
_{Check Time}	_{35.02s (± 0.13%)}	_{34.95s (± 0.36%)}	_~	_34.76s	_35.13s	_{p=0.229 n=6}
_{Emit Time}	_{3.32s (± 2.54%)}	_{3.36s (± 1.50%)}	_~	_3.27s	_3.42s	_{p=0.172 n=6}
_{Total Time}	_{45.35s (± 0.23%)}	_{45.27s (± 0.35%)}	_~	_45.09s	_45.50s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,471	_258,471	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,867	_104,867	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,701k (± 0.01%)}	_{427,793k (± 0.03%)}	_~	_427,665k	_427,992k	_{p=0.109 n=6}
_{Parse Time}	_{3.35s (± 0.53%)}	_{3.35s (± 1.25%)}	_~	_3.30s	_3.41s	_{p=0.686 n=6}
_{Bind Time}	_{1.32s (± 1.82%)}	_{1.33s (± 0.63%)}	_~	_1.31s	_1.33s	_{p=1.000 n=6}
_{Check Time}	_{17.96s (± 0.31%)}	_{18.04s (± 0.29%)}	_{0.08s ( 0.45%)}	_17.96s	_18.12s	_{p=0.043 n=6}
_{Emit Time}	_{1.63s (± 0.93%)}	_{1.63s (± 1.27%)}	_~	_1.60s	_1.66s	_{p=0.405 n=6}
_{Total Time}	_{24.26s (± 0.39%)}	_{24.34s (± 0.13%)}	_~	_24.29s	_24.38s	_{p=0.108 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,607k (± 0.03%)}	_{369,576k (± 0.03%)}	_~	_369,442k	_369,751k	_{p=0.873 n=6}
_{Parse Time}	_{3.43s (± 0.65%)}	_{3.42s (± 0.78%)}	_~	_3.38s	_3.46s	_{p=0.678 n=6}
_{Bind Time}	_{1.94s (± 1.05%)}	_{1.93s (± 0.97%)}	_~	_1.91s	_1.96s	_{p=0.871 n=6}
_{Check Time}	_{19.33s (± 0.27%)}	_{19.32s (± 0.42%)}	_~	_19.21s	_19.45s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.70s (± 0.28%)}	_{24.68s (± 0.36%)}	_~	_24.56s	_24.78s	_{p=0.748 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,971,932	_2,971,932	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,020,692	_1,020,692	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,096,420k (± 0.00%)}	_{3,096,375k (± 0.00%)}	_~	_3,096,313k	_3,096,431k	_{p=0.230 n=6}
_{Parse Time}	_{17.07s (± 0.29%)}	_{17.08s (± 0.19%)}	_~	_17.04s	_17.11s	_{p=0.872 n=6}
_{Bind Time}	_{5.25s (± 2.37%)}	_{5.26s (± 2.72%)}	_~	_5.15s	_5.46s	_{p=1.000 n=6}
_{Check Time}	_{96.38s (± 0.23%)}	_{95.97s (± 0.28%)}	_{-0.42s (- 0.43%)}	_95.62s	_96.34s	_{p=0.020 n=6}
_{Emit Time}	_{24.98s (± 0.75%)}	_{24.87s (± 0.41%)}	_~	_24.74s	_24.99s	_{p=0.422 n=6}
_{Total Time}	_{143.67s (± 0.22%)}	_{143.17s (± 0.16%)}	_{-0.50s (- 0.35%)}	_142.87s	_143.50s	_{p=0.020 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,282	_267,282	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,835	_108,835	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,825k (± 0.02%)}	_{411,838k (± 0.02%)}	_~	_411,763k	_411,947k	_{p=1.000 n=6}
_{Parse Time}	_{3.84s (± 0.43%)}	_{3.83s (± 0.49%)}	_~	_3.81s	_3.86s	_{p=1.000 n=6}
_{Bind Time}	_{1.69s (± 0.31%)}	_{1.67s (± 0.82%)}	_~	_1.66s	_1.69s	_{p=0.102 n=6}
_{Check Time}	_{16.80s (± 0.41%)}	_{16.86s (± 0.27%)}	_~	_16.80s	_16.93s	_{p=0.106 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.33s (± 0.28%)}	_{22.37s (± 0.22%)}	_~	_22.30s	_22.42s	_{p=0.296 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_510,479	_510,479	_~	_~	_~	_{p=1.000 n=6}
_Types	_161,598	_161,598	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,985k (± 0.09%)}	_{448,171k (± 0.09%)}	_~	_447,689k	_448,535k	_{p=0.336 n=6}
_{Parse Time}	_{3.15s (± 1.34%)}	_{3.16s (± 0.38%)}	_~	_3.15s	_3.18s	_{p=0.089 n=6}
_{Bind Time}	_{1.18s (± 0.54%)}	_{1.18s (± 1.07%)}	_~	_1.17s	_1.20s	_{p=0.799 n=6}
_{Check Time}	_{17.14s (± 0.48%)}	_{17.15s (± 0.56%)}	_~	_17.04s	_17.27s	_{p=0.571 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.47s (± 0.50%)}	_{21.50s (± 0.44%)}	_~	_21.38s	_21.61s	_{p=0.574 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-17T19:11:10Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59325/merge:

Everything looks good!

jakebailey · 2024-07-17T19:16:31Z

Everything seems fine in the above; @weswigham is there a major downside to removing this bit?

rbuckton · 2024-07-17T19:26:25Z

I think the only declare that effects runtime emit are declare fields with decorators. Should we preserve all ambients, or should this fix be more narrowly focused?

jakebailey · 2024-07-17T19:30:18Z

I think the only declare that effects runtime emit are declare fields with decorators. Should we preserve all ambients, or should this fix be more narrowly focused?

I can scope it down, the trouble is just that there's an "unspecified" hint which is hit from noCheck as it's not actually walking things the same way as we do the checker, so I have to disable it for that category as well. I wasn't sure how bad that'd be, but it did work fine too.

We just didn't have this optimization at all in the original code before #58366 so reverting it seemed okayish.

weswigham · 2024-07-17T19:36:14Z

src/compiler/checker.ts

@@ -29679,9 29679,6 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
 if (!canCollectSymbolAliasAccessabilityData) {
 return;
 }
- if (location.flags & NodeFlags.Ambient) {


Yeah, I wouldn't want to remove this outright - perf tests won't show it, but this is pretty important to keep this fast from my testing. I'd just except ambient property signatures from the early skip, since they're like... not really ambient? It looks like when we have something like

class A { @decorator(class B {}) declare prop: string; }

the prop is ambient marked, but the decorator is not, so we should just be able to except the prop, like @rbuckton says.

if (location.flags & NodeFlags.Ambient && !isPropertySignature(location) && !isPropertyDeclaration(location)) {

seems like it aughta work?

Done; that seemed to be enough.

declare fields aren't quite as ambient as other declarations. They were added as a compatiblity mechanism due to native class fields using Define semantics, with legacy decorators being one of the main motivations.

jakebailey · 2024-07-17T20:56:51Z

Updated; PTAL

weswigham

Funky to me that we allow a supposedly ambient prop to be decorated at all - seems like that kinda forces it to be non-ambient 🤷‍♂️

jakebailey · 2024-07-17T23:01:41Z

@typescript-bot cherry-pick this to release-5.5

typescript-bot · 2024-07-17T23:01:44Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.5`	✅ Started	✅ Results

typescript-bot · 2024-07-17T23:04:21Z

Hey, @jakebailey! I've created #59336 for you.

…e-5.5 (#59336) Co-authored-by: Jake Bailey <5341706 [email protected]>

jakebailey added 2 commits July 17, 2024 10:10

Add test

0fd3b42

Don't skip markLinkedReferences on ambients

fdf4432

jakebailey requested review from weswigham, andrewbranch and rbuckton July 17, 2024 17:20

typescript-bot assigned jakebailey Jul 17, 2024

typescript-bot added the Author: Team label Jul 17, 2024

typescript-bot assigned rbuckton Jul 17, 2024

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 17, 2024

weswigham reviewed Jul 17, 2024

View reviewed changes

PR feedback

e6407a8

jakebailey changed the title ~~Don't skip markLinkedReferences on ambients~~ Don't skip markLinkedReferences on ambient properties Jul 17, 2024

jakebailey requested a review from weswigham July 17, 2024 20:55

weswigham approved these changes Jul 17, 2024

View reviewed changes

typescript-bot mentioned this pull request Jul 17, 2024

🤖 Pick PR #59325 (Don't skip markLinkedReferences on ...) into release-5.5 #59336

Merged

jakebailey merged commit 95a968c into microsoft:main Jul 17, 2024
29 checks passed

jakebailey deleted the fix-59051 branch July 17, 2024 23:10

DanielRosenwasser added this to the TypeScript 5.5.4 milestone Jul 17, 2024

DanielRosenwasser pushed a commit that referenced this pull request Jul 17, 2024

🤖 Pick PR #59325 (Don't skip markLinkedReferences on ...) into releas…

f35206d

…e-5.5 (#59336) Co-authored-by: Jake Bailey <5341706 [email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't skip markLinkedReferences on ambient properties #59325

Don't skip markLinkedReferences on ambient properties #59325

jakebailey commented Jul 17, 2024

jakebailey commented Jul 17, 2024

typescript-bot commented Jul 17, 2024 •

edited

Loading

typescript-bot commented Jul 17, 2024

typescript-bot commented Jul 17, 2024

typescript-bot commented Jul 17, 2024

tsc

typescript-bot commented Jul 17, 2024

jakebailey commented Jul 17, 2024

rbuckton commented Jul 17, 2024

jakebailey commented Jul 17, 2024

weswigham Jul 17, 2024

jakebailey Jul 17, 2024

rbuckton Jul 17, 2024

jakebailey commented Jul 17, 2024

weswigham left a comment

jakebailey commented Jul 17, 2024

typescript-bot commented Jul 17, 2024 •

edited

Loading

typescript-bot commented Jul 17, 2024

Don't skip markLinkedReferences on ambient properties #59325

Don't skip markLinkedReferences on ambient properties #59325

Conversation

jakebailey commented Jul 17, 2024

jakebailey commented Jul 17, 2024

typescript-bot commented Jul 17, 2024 • edited Loading

typescript-bot commented Jul 17, 2024

typescript-bot commented Jul 17, 2024

typescript-bot commented Jul 17, 2024

tsc

typescript-bot commented Jul 17, 2024

jakebailey commented Jul 17, 2024

rbuckton commented Jul 17, 2024

jakebailey commented Jul 17, 2024

weswigham Jul 17, 2024

Choose a reason for hiding this comment

jakebailey Jul 17, 2024

Choose a reason for hiding this comment

rbuckton Jul 17, 2024

Choose a reason for hiding this comment

jakebailey commented Jul 17, 2024

weswigham left a comment

Choose a reason for hiding this comment

jakebailey commented Jul 17, 2024

typescript-bot commented Jul 17, 2024 • edited Loading

typescript-bot commented Jul 17, 2024

typescript-bot commented Jul 17, 2024 •

edited

Loading

typescript-bot commented Jul 17, 2024 •

edited

Loading