-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(59011): TypeScript generates invalid types if @import tags are spread over multiple lines #59026
Conversation
…sterisks from the identifier range
@typescript-bot perf test this faster |
@typescript-bot cherry-pick this to release-5.5 |
Hey, @DanielRosenwasser! I've created #59039 for you. |
@DanielRosenwasser Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
I think we will schedule this for a follow-up patch. I want to get 5.5.3 out today. |
I think this is good enough to merge once @a-tarasyuk has a chance to confirm that the scanner changes are infeasible (or, if they're feasible, to make the changes). Can you check whether adjusting fullStartPos after |
Modifying /*HIGHLIGHTS*/<|[|{| kind: "reference" |}foo|]: string;
// * |> The first issue can be fixed by adjusting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the complexity of a better fix, let's take this with the idea of improving the scanner's ability to skip *
in the future.
(Based on discussion between me and @jakebailey .)
@a-tarasyuk would you mind bringing this branch up to date with main?
…e-5.5 (#59039) Co-authored-by: Oleksandr T <[email protected]>
Fixes #59011