Always resolve package.json exports in type reference directives #58638
293
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
added
Breaking Change
typescript-bot
added
the
For Uncommitted Bug
andrewbranch
commented
May 23, 2024
| @@ -14,6 14,7 @@ export const a = <div></div>; | |||
| "main": "", | |||
| "types": "index.d.ts", | |||
| "exports": { | |||
| ".": "./index.d.ts", | |||
There was a problem hiding this comment.
Like in normal module resolution, a failed exports lookup ends the resolution process. We could decide to deviate from normal module resolution and fall back to types/main/index.d.ts if this fails—that would eliminate all the new errors we see in baselines, I think.
|
@typescript-bot test top400 |
|
@andrewbranch Here are the results of running the top 400 repos comparing Something interesting changed - please have a look. Details
|
|
@andrewbranch Here are some more interesting changes from running the top 400 repos suite Details
|
|
@andrewbranch Here are some more interesting changes from running the top 400 repos suite Details
|
|
@andrewbranch Here are some more interesting changes from running the top 400 repos suite Details
|
|
@andrewbranch Here are some more interesting changes from running the top 400 repos suite Details
|
|
@andrewbranch Here are some more interesting changes from running the top 400 repos suite Details
|
|
@andrewbranch Here are some more interesting changes from running the top 400 repos suite Details
|
|
@andrewbranch Here are some more interesting changes from running the top 400 repos suite Details
|
|
@andrewbranch Here are some more interesting changes from running the top 400 repos suite Details
|
|
Lol, this might be too breaky as-is 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not planning to merge before 5.6.
Fixes #47444