Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(57386): Invalid use of 'eval' when defining a namespaced eval function #57391

Merged
merged 2 commits into from
Mar 1, 2024
Merged

fix(57386): Invalid use of 'eval' when defining a namespaced eval function #57391

merged 2 commits into from
Mar 1, 2024

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #57386

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 12, 2024
sandersn
sandersn requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be restricted to namespaced-contained functions, or else have a lot more tests with examples of ambient variables, functions, etc named eval.

src/compiler/binder.ts Show resolved Hide resolved
@sandersn sandersn self-assigned this Feb 27, 2024
@sandersn sandersn merged commit 8ada4ef into microsoft:main Mar 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh left review comments

@sandersn sandersn sandersn approved these changes

@navya9singh navya9singh Awaiting requested review from navya9singh

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid use of 'eval' when defining a namespaced eval function
4 participants
@a-tarasyuk @sandersn @RyanCavanaugh @typescript-bot