Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(57028): Support inlining variables that are used in object literal shorthand #57051

Merged
merged 4 commits into from
Jan 18, 2024
Merged

feat(57028): Support inlining variables that are used in object literal shorthand #57051

merged 4 commits into from
Jan 18, 2024

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #57028

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 14, 2024
@DanielRosenwasser
Copy link
Member

@typescript-bot test tsserver top120

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 18, 2024 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 734d4fb. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/57051/merge:

Something interesting changed - please have a look.

Details

Server exited prematurely with code unknown and signal SIGABRT 

Server exited prematurely with code unknown and signal SIGABRT

Affected repos

calcom/cal.com Raw error text: RepoResults6/calcom.cal.com.rawError.txt in the artifact folder

Last few requests

{"seq":731,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/apps/storybook/tailwind.config.js","line":2,"offset":5}}
{"seq":732,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/apps/storybook/tailwind.config.js","line":6,"offset":16}}
{"seq":733,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/apps/api/test/lib/middleware/addRequestId.test.ts"],"openFiles":[]}}
{"seq":734,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/apps/web/abTest/utils.ts","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro steps

  1. git clone https://github.com/calcom/cal.com --recurse-submodules
  2. In dir cal.com, run git reset --hard 9076a7eb42b035959e77268d92b9bc989ab5e6fd
  3. In dir cal.com, run yarn install --no-immutable --mode=skip-build
  4. Back in the initial folder, download RepoResults6/calcom.cal.com.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./cal.com ./calcom.cal.com.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

@MariaSolOs MariaSolOs merged commit 55153b0 into microsoft:main Jan 18, 2024
19 checks passed
This was referenced Jan 19, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@MariaSolOs MariaSolOs MariaSolOs approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support inlining variables that are used in object literal shorthand
4 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot @MariaSolOs