Experiment: Produce wide index signatures from the spread of an index signature #56441

andrewbranch · 2023-11-17T00:52:26Z

Fixes #56431
Related: #27273 (does not change the behavior of dropping index signatures from the left side of a spread)

This would need a lot more test coverage if it proves viable but wanted to run the top repos first.

andrewbranch · 2023-11-17T00:52:50Z

@typescript-bot perf test this
@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test top200

typescript-bot · 2023-11-17T00:52:53Z

Heya @andrewbranch, I"ve started to run the diff-based user code test suite on this PR at 85c7e7a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-17T00:52:53Z

Heya @andrewbranch, I"ve started to run the diff-based top-repos suite on this PR at 85c7e7a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-17T00:52:53Z

Heya @andrewbranch, I"ve started to run the parallelized Definitely Typed test suite on this PR at 85c7e7a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-17T00:52:53Z

Heya @andrewbranch, I"ve started to run the regular perf test suite on this PR at 85c7e7a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-17T01:13:07Z

@andrewbranch Here are the results of running the user test suite comparing main and refs/pull/56441/merge:

There were infrastructure failures potentially unrelated to your change:

2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module "@pptr/testserver" or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

webpack

tsconfig.types.json

[NEW] error TS2345: Argument of type "{ [x: string]: any; _parent: Object; _element: string; type: string; constructor?: Function | undefined; toString?: (() => string) | undefined; toLocaleString?: (() => string) | undefined; valueOf?: (() => Object) | undefined; hasOwnProperty?: ((v: PropertyKey) => boolean) | undefined; isPrototypeOf?: ((v: Object) =..." is not assignable to parameter of type "Object".
- lib/stats/StatsPrinter.js#L223
[MISSING] error TS2345: Argument of type "{ _parent: Object; _element: string; type: string; constructor?: Function | undefined; toString?: (() => string) | undefined; toLocaleString?: (() => string) | undefined; valueOf?: (() => Object) | undefined; hasOwnProperty?: ((v: PropertyKey) => boolean) | undefined; isPrototypeOf?: ((v: Object) => boolean) | undef..." is not assignable to parameter of type "Object".
- lib/stats/StatsPrinter.js#L223

typescript-bot · 2023-11-17T01:13:49Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,163k (± 0.01%)}	_{295,169k (± 0.02%)}	_~	_295,081k	_295,248k	_{p=0.689 n=6}
_{Parse Time}	_{2.64s (± 0.24%)}	_{2.64s (± 0.68%)}	_~	_2.61s	_2.66s	_{p=0.737 n=6}
_{Bind Time}	_{0.83s (± 0.91%)}	_{0.83s (± 0.76%)}	_~	_0.82s	_0.84s	_{p=0.718 n=6}
_{Check Time}	_{8.06s (± 0.33%)}	_{8.06s (± 0.22%)}	_~	_8.04s	_8.09s	_{p=0.746 n=6}
_{Emit Time}	_{7.07s (± 0.21%)}	_{7.08s (± 0.11%)}	_~	_7.07s	_7.09s	_{p=0.315 n=6}
_{Total Time}	_{18.61s (± 0.21%)}	_{18.61s (± 0.16%)}	_~	_18.56s	_18.65s	_{p=0.871 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,680k (± 1.27%)}	_{191,687k (± 1.24%)}	_~	_190,693k	_196,542k	_{p=0.128 n=6}
_{Parse Time}	_{1.36s (± 0.98%)}	_{1.36s (± 0.89%)}	_~	_1.35s	_1.38s	_{p=0.591 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.16s (± 0.38%)}	_{9.16s (± 0.45%)}	_~	_9.13s	_9.24s	_{p=1.000 n=6}
_{Emit Time}	_{2.65s (± 0.73%)}	_{2.64s (± 0.57%)}	_~	_2.62s	_2.66s	_{p=0.279 n=6}
_{Total Time}	_{13.88s (± 0.29%)}	_{13.87s (± 0.30%)}	_~	_13.83s	_13.95s	_{p=0.627 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,349k (± 0.00%)}	_{347,359k (± 0.00%)}	_~	_347,339k	_347,367k	_{p=0.199 n=6}
_{Parse Time}	_{2.45s (± 0.45%)}	_{2.45s (± 0.49%)}	_~	_2.43s	_2.46s	_{p=0.432 n=6}
_{Bind Time}	_{0.92s (± 0.56%)}	_{0.92s (± 0.44%)}	_~	_0.92s	_0.93s	_{p=0.595 n=6}
_{Check Time}	_{6.90s (± 0.30%)}	_{6.92s (± 0.40%)}	_~	_6.87s	_6.94s	_{p=0.168 n=6}
_{Emit Time}	_{4.05s (± 0.43%)}	_{4.05s (± 0.74%)}	_~	_4.03s	_4.11s	_{p=1.000 n=6}
_{Total Time}	_{14.33s (± 0.10%)}	_{14.35s (± 0.30%)}	_~	_14.31s	_14.43s	_{p=0.222 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,617k (± 0.01%)}	_{302,634k (± 0.00%)}	_~	_302,615k	_302,650k	_{p=0.092 n=6}
_{Parse Time}	_{1.99s (± 0.75%)}	_{1.99s (± 1.68%)}	_~	_1.95s	_2.03s	_{p=0.747 n=6}
_{Bind Time}	_{1.00s (± 1.09%)}	_{1.00s (± 0.98%)}	_~	_0.99s	_1.02s	_{p=0.718 n=6}
_{Check Time}	_{6.26s (± 0.34%)}	_{6.26s (± 0.30%)}	_~	_6.24s	_6.29s	_{p=0.808 n=6}
_{Emit Time}	_{3.58s (± 0.34%)}	_{3.59s (± 0.52%)}	_~	_3.58s	_3.63s	_{p=0.111 n=6}
_{Total Time}	_{12.82s (± 0.15%)}	_{12.84s (± 0.24%)}	_~	_12.80s	_12.87s	_{p=0.292 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,568k (± 0.00%)}	_{470,584k (± 0.01%)}	_~	_470,539k	_470,630k	_{p=0.575 n=6}
_{Parse Time}	_{2.57s (± 0.77%)}	_{2.58s (± 0.68%)}	_~	_2.56s	_2.61s	_{p=0.324 n=6}
_{Bind Time}	_{0.99s (± 0.76%)}	_{0.99s (± 1.38%)}	_~	_0.97s	_1.01s	_{p=0.672 n=6}
_{Check Time}	_{16.66s (± 0.29%)}	_{16.71s (± 0.50%)}	_~	_16.62s	_16.84s	_{p=0.228 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.21s (± 0.26%)}	_{20.28s (± 0.40%)}	_~	_20.18s	_20.40s	_{p=0.170 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,827k (± 0.01%)}	_{512,808k (± 0.01%)}	_~	_512,771k	_512,835k	_{p=0.378 n=6}
_{Parse Time}	_{3.27s (± 0.19%)}	_{3.28s (± 0.32%)}	_~	_3.26s	_3.29s	_{p=0.388 n=6}
_{Bind Time}	_{1.55s (± 0.33%)}	_{1.54s (± 0.68%)}	_~	_1.53s	_1.56s	_{p=0.794 n=6}
_{Check Time}	_{2.85s (± 0.50%)}	_{2.85s (± 0.81%)}	_~	_2.81s	_2.87s	_{p=0.686 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{7.75s (± 0.23%)}	_{7.75s (± 0.37%)}	_~	_7.70s	_7.77s	_{p=0.746 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,355ms (± 0.61%)}	_{2,361ms (± 0.69%)}	_~	_2,342ms	_2,381ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{5,400ms (± 1.50%)}	_{5,398ms (± 1.70%)}	_~	_5,294ms	_5,497ms	_{p=1.000 n=6}
_{Req 3 - references}	_{325ms (± 0.75%)}	_{325ms (± 0.79%)}	_~	_322ms	_329ms	_{p=0.629 n=6}
_{Req 4 - navto}	_{277ms (± 1.03%)}	_{277ms (± 1.22%)}	_~	_273ms	_280ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 6.42%)}	_{85ms (± 5.81%)}	_~	_80ms	_90ms	_{p=0.621 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,494ms (± 0.76%)}	_{2,502ms (± 0.86%)}	_~	_2,479ms	_2,530ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{4,106ms (± 1.89%)}	_{4,055ms (± 1.49%)}	_~	_4,016ms	_4,177ms	_{p=0.199 n=6}
_{Req 3 - references}	_{338ms (± 1.82%)}	_{342ms (± 1.44%)}	_~	_332ms	_345ms	_{p=0.257 n=6}
_{Req 4 - navto}	_{283ms (± 0.77%)}	_{284ms (± 0.37%)}	_~	_282ms	_285ms	_{p=0.625 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 6.73%)}	_{88ms (± 5.56%)}	_~	_78ms	_90ms	_{p=0.120 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,863ms (± 0.52%)}	_{2,591ms (± 0.36%)}	_~	_2,580ms	_2,601ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,712ms (± 1.94%)}	_{1,716ms (± 1.81%)}	_~	_1,695ms	_1,771ms	_{p=0.575 n=6}
_{Req 3 - references}	_{117ms (± 6.23%)}	_{108ms (± 7.68%)}	_~	_102ms	_122ms	_{p=0.089 n=6}
_{Req 4 - navto}	_{366ms (± 0.61%)}	_{368ms (± 1.56%)}	_~	_358ms	_376ms	_{p=0.513 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{309ms (± 2.34%)}	_{308ms (± 2.66%)}	_~	_297ms	_320ms	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.77ms (± 0.18%)}	_{152.71ms (± 0.16%)}	_~	_151.71ms	_154.94ms	_{p=0.053 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.34ms (± 0.16%)}	_{228.13ms (± 0.14%)}	_{-0.22ms (- 0.10%)}	_226.93ms	_231.27ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.71ms (± 0.16%)}	_{229.76ms (± 0.19%)}	_~	_228.04ms	_236.99ms	_{p=0.807 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.94ms (± 0.18%)}	_{228.70ms (± 0.18%)}	_{-0.25ms (- 0.11%)}	_227.05ms	_232.98ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-11-17T01:44:06Z

Hey @andrewbranch, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-11-17T03:08:50Z

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/56441/merge:

Something interesting changed - please have a look.

Details

ant-design/ant-design

tsconfig.json

error TS2322: Type "{ [x: string]: string | boolean; allowClear: true; defaultValue: string; }" is not assignable to type "InputProps".
- components/input/__tests__/index.test.tsx#L365
error TS2322: Type "{ [x: string]: { [x: string]: string | number | boolean | string[] | (string & {}) | CSSObject | ArrayCSSInterpolation | Keyframes | Property.Filter[] | ... 1540 more ... | undefined; ... 940 more ...; ":visited"?: CSSObject | undefined; }; }" is not assignable to type "CSSObject".
- components/tree/style/index.ts#L99

backstage/backstage

5 of 13 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2322: Type "{ [x: string]: { logLevel: string; } | { logLevel: ExtractorLogLevel.Warning; addToApiReportFile: true; }; default: { logLevel: ExtractorLogLevel.Warning; addToApiReportFile: true; }; }" is not assignable to type "IConfigMessageReportingTable".
- packages/repo-tools/src/commands/api-reports/api-extractor.ts#L430

ionic-team/ionicons

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2322: Type "{ [x: string]: boolean | undefined; "flip-rtl": boolean; "icon-rtl": boolean; "ion-color"?: boolean | undefined; }" is not assignable to type "string | { [className: string]: boolean; } | undefined".
- src/components/icon/icon.tsx#L174

microsoft/vscode

4 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2322: Type "{ [x: string]: string | null | undefined; VSCODE_AMD_ENTRYPOINT: string; VSCODE_HANDLES_UNCAUGHT_ERRORS: string; VSCODE_NLS_CONFIG: string; TZ?: string | undefined; }" is not assignable to type "IProcessEnvironment".
- src/vs/server/node/extensionHostConnection.ts#L40

recharts/recharts

2 of 3 projects failed to build with the old tsc and were ignored

demo/tsconfig.json

error TS2322: Type "{ [x: number]: { hide: true; orientation: any; domain: number[]; originalDomain: (string | number)[]; isCategorical: boolean; layout: LayoutType; type?: "number" | "category"; dataKey?: DataKey<any>; ... 17 more ...; className?: string; }; }" is not assignable to type "AxisMap".
- src/chart/generateCategoricalChart.tsx#L550

redwoodjs/redwood

50 of 65 projects failed to build with the old tsc and were ignored

packages/router/src/typetests/tsconfig.json

error TS2322: Type "{ [x: string]: unknown; }" is not assignable to type "Record<string, string>".
- packages/router/src/router.tsx#L179 in packages/router/tsconfig.json

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2322: Type "{ [x: string]: string | undefined; LANG: string; TERM: string; COLORTERM: string; TERM_PROGRAM: string; TERM_PROGRAM_VERSION: string; TZ?: string | undefined; } | { [x: string]: string; LANG: string; TERM: string; COLORTERM: string; TERM_PROGRAM: string; TERM_PROGRAM_VERSION: string; }" is not assignable to type "Record<string, string>".
- app/session.ts#L123 in app/tsconfig.json

andrewbranch added 2 commits November 16, 2023 16:44

Produce wide index signatures from the spread of an index signature

d088733

Update existing baselines

85c7e7a

typescript-bot assigned andrewbranch Nov 17, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 17, 2023

Andarist mentioned this pull request Oct 31, 2024

Destructuring into an empty object vs an object with existing properties yields different results #60386

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experiment: Produce wide index signatures from the spread of an index signature #56441

Experiment: Produce wide index signatures from the spread of an index signature #56441

andrewbranch commented Nov 17, 2023

andrewbranch commented Nov 17, 2023

typescript-bot commented Nov 17, 2023 •

edited

Loading

typescript-bot commented Nov 17, 2023 •

edited

Loading

typescript-bot commented Nov 17, 2023 •

edited

Loading

typescript-bot commented Nov 17, 2023 •

edited

Loading

typescript-bot commented Nov 17, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

webpack

tsconfig.types.json

typescript-bot commented Nov 17, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 17, 2023

typescript-bot commented Nov 17, 2023

ant-design/ant-design

tsconfig.json

backstage/backstage

tsconfig.json

ionic-team/ionicons

tsconfig.json

microsoft/vscode

src/tsconfig.tsec.json

recharts/recharts

demo/tsconfig.json

redwoodjs/redwood

packages/router/src/typetests/tsconfig.json

vercel/hyper

tsconfig.json

Experiment: Produce wide index signatures from the spread of an index signature #56441

Are you sure you want to change the base?

Experiment: Produce wide index signatures from the spread of an index signature #56441

Conversation

andrewbranch commented Nov 17, 2023

andrewbranch commented Nov 17, 2023

typescript-bot commented Nov 17, 2023 • edited Loading

typescript-bot commented Nov 17, 2023 • edited Loading

typescript-bot commented Nov 17, 2023 • edited Loading

typescript-bot commented Nov 17, 2023 • edited Loading

typescript-bot commented Nov 17, 2023

typescript-bot commented Nov 17, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 17, 2023

typescript-bot commented Nov 17, 2023

typescript-bot commented Nov 17, 2023 •

edited

Loading

typescript-bot commented Nov 17, 2023 •

edited

Loading

typescript-bot commented Nov 17, 2023 •

edited

Loading

typescript-bot commented Nov 17, 2023 •

edited

Loading