Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No property access from index signature fix #41793

Merged

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Dec 3, 2020

Fixes #41787
Fixes #41786
Fixes #41785

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Dec 3, 2020
@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 3, 2020

I don't know why the test jsDeclarationsSubclassWithExplicitNoArgumentConstructor changes.
But seems not my bad?

@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 3, 2020

#41803

@armanio123 armanio123 closed this Dec 4, 2020
@armanio123 armanio123 reopened this Dec 4, 2020
@@ -0,0 1,16 @@
/// <reference path='fourslash.ts'/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the file is incorrect.

@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 4, 2020

@orta
Could @typescript-bot merge master & push automatically?
Or Github has similar features In my memory, but I haven't seen in this repo.

@Kingwl Kingwl force-pushed the noPropertyAccessFromIndexSignature_fix branch from d298975 to 4f8fde3 Compare December 4, 2020 04:47
@armanio123 armanio123 merged commit 3c7ac73 into microsoft:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
5 participants