fix(41534): Maximum call stack error while computing document symbol file #41543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
armanio123
requested changes
Nov 19, 2020
There was a problem hiding this comment.
Thanks for the fix and the tests. This takes away the exception but looks incorrect that it uses "kind"": "constructor" instead of function. Happens as well for other syntax.
For example:
class Foo { }
let Foo = 1; // This is marked as "constructor" when it should be "let".
Could you take another look at the fix?
a-tarasyuk
force-pushed
the
fix/41534
branch
from
1e053bc
to
61a7c3e
Compare
a-tarasyuk
force-pushed
the
fix/41534
branch
from
61a7c3e
to
9bcbca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41534