-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unarchiving read-only folders fails #391
Comments
I'm not working on v3 anymore. But this is good to know for v4, in case we do add unarchiving capabilities: #311 Maybe a better solution would be to apply folder permissions after extraction is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of the package or command are you using?
v3.5.1
What are you trying to do?
Trying to extract a tar.gz file (which I suspect might replicate with other archive formats) that contains a read-only folder along with its files.
What steps did you take?
Create an archive with a write-protected folder:
What did you expect to happen, and what actually happened instead?
An error returned:
reading file in tar archive: /path/TestArchive/writeprotectedfolder/file2.txt: creating new file: open /path/TestArchive/writeprotectedfolder/file2.txt: permission denied
How do you think this should be fixed?
The issue arises when the code creates the
writeprotectedfolder
with its original read-only permissions (https://github.com/mholt/archiver/blob/v3.5.1/tar.go#L264). Consequently, we encounter an inability to writefile1.txt
andfile2.txt
into it. I intended to initiate a pull request to address this, but I am unable to do so as the master branch points to v4, and there isn't a v3 branch available.Please link to any related issues, pull requests, and/or discussion
I believe that this pull request has caused the issue: #133.
The text was updated successfully, but these errors were encountered: