-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo causing problems on windows due to symlink #148
Comments
I like that idea, and perhaps the tests for v4 (currently in #302 but not sure when I'll get around to adding the tests yet) can adopt this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Git is constantly telling me that there are changes to the file/symlink:
vendor/github.com/mholt/archiver/testdata/exist
This breaks the go
dep
dependency/vendor tool.The issue appears to be because when windows or bash or git see the symlink, they add a
C:
to the front of the file name.prometheus/procfs had a similar issue, that they solved: prometheus/procfs#60
Alternatively, just create the symlinks when the tests are run, rather than commit them to git.
What version of the package or command are you using?
bfece90
What are you trying to do?
on one project that has this as a dependency i am trying to run
dep ensure -update
What steps did you take?
Be on windows
What did you expect to happen, and what actually happened instead?
Not have git constantly tell me there are differences, and prevent me from checking out other branches, because it thinks there are changes to this file.
How do you think this should be fixed?
prometheus/procfs had a similar issue, and they fixed it: prometheus/procfs#60
I'm not sure if their fix is necessarily applicable.
Maybe don't have the symlinks in the git repo and instead generate them when the tests are run?
The text was updated successfully, but these errors were encountered: