Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode lpc fix for unary #68

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

MarkKremer
Copy link
Collaborator

Fix as described in #66 (comment)

@mewmew
Copy link
Member

mewmew commented Oct 31, 2023

Wow! So happy you managed to find the underlying issue for the failing 44 - ...flac test case @MarkKremer. Really happy to have this resolved, as we now gain capabilities for LPC encoding in mewkiz/flac : )

Cheers,
Henry & Robin

@mewmew mewmew merged commit 04bdc43 into mewkiz:encode-lpc Oct 31, 2023
mewmew pushed a commit that referenced this pull request Oct 31, 2023
* Support writing Unaries above 255

* Improve unary test error messages

* Update comment on "44 - ...flac" test
@MarkKremer MarkKremer deleted the encode-lpc-unary-fix branch October 31, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants