rose-arch: Raise error for duplicate targets. #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
requested changes
Jan 12, 2018
lib/python/rose/apps/rose_arch.py
Outdated
|
|
||
| # Don't permit duplicate targets. | ||
| if s_key_tail in s_key_tails: | ||
| raise Exception('%s: Duplicate target "%s".' % ( |
There was a problem hiding this comment.
Recommend that you raise a ConfigValueError.
matthewrmshin
approved these changes
Jan 25, 2018
|
(Travis CI failure safe to ignore.) |
|
@sadielbartholomew please sanity check. |
sadielbartholomew
approved these changes
Jan 25, 2018
| @@ -39,6 39,13 @@ | |||
| from time import gmtime, strftime, time | |||
|
|
|||
|
|
|||
| class RoseArchDuplicateError(ConfigValueError): | |||
|
|
|||
| """An exception raised if dupluicate archive targets are provided.""" | |||
There was a problem hiding this comment.
Typo: 'dupluicate'
There was a problem hiding this comment.
Merging and amending typo quickly with a separate PR, as advised by Matt.
sadielbartholomew
added a commit
to sadielbartholomew/rose
that referenced
this pull request
Jan 25, 2018
matthewrmshin
added a commit
that referenced
this pull request
Jan 25, 2018
Fix docstring typo from #2138 merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to pass rose arch a pair of duplicate targets using the
[arch:(target)]syntax e.g:This PR catches the configuration error before it surfaces from sqlite to provide a more helpful error.