fix: fix transpose empty iterable with zip(*nested) in transformations
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
XuehaiPan
added
bug
XuehaiPan
force-pushed
the
empty-transpose
branch
from
35b8642 to
a6fb8ec
Compare
XuehaiPan
changed the title
zip(*nested)zip(*nested) in transformations
XuehaiPan
force-pushed
the
empty-transpose
branch
from
a6fb8ec to
1357e92
Compare
XuehaiPan
force-pushed
the
empty-transpose
branch
from
1357e92 to
e0c41cf
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 91.97% 92.97% +1.00%
==========================================
Files 66 66
Lines 2564 2574 +10
==========================================
+ Hits 2358 2393 +35
+ Misses 206 181 -25
Flags with carried forward coverage won"t be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
XuehaiPan
force-pushed
the
empty-transpose
branch
from
125d8a8 to
af61b08
Compare
XuehaiPan
force-pushed
the
empty-transpose
branch
from
af61b08 to
fd1642c
Compare
XuehaiPan
force-pushed
the
empty-transpose
branch
2 times, most recently
from
f945060 to
4357eb3
Compare
XuehaiPan
force-pushed
the
empty-transpose
branch
from
4357eb3 to
5ae44b5
Compare
Benjamin-eecs
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don"t hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)