Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If topic title ends up blank somehow, there is no way to change it #1143

Open
Connoropolous opened this issue Sep 22, 2017 · 1 comment
Open
Labels

Comments

@Connoropolous
Copy link
Member

this is because when you open the topic card, there is nothing to 'click to edit'

@devvmh
Copy link
Contributor

devvmh commented Sep 23, 2017

This is pretty easy to fix

diff --git a/frontend/src/components/TopicCard/Title.js b/frontend/src/components/TopicCard/Title.js
index 4ebdeedd..26b6da16 100644
--- a/frontend/src/components/TopicCard/Title.js
    b/frontend/src/components/TopicCard/Title.js
@@ -14,7  14,7 @@ class Title extends Component {
     if (this.props.authorizedToEdit) {
       return (
         <span className="title">
-          <RIETextArea value={this.props.name}
           <RIETextArea value={this.props.name || "Click to edit"}
             ref={textarea => { this.textarea = textarea }}
             propName="name"
             change={this.props.onChange}

But then if you "cancel" editing by hitting enter or clicking out of the box, it updates the name of the topic to "Click to edit". I'm not sure what the best UX is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants