Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use metalsmith-in-place #320

Closed

Conversation

DavidBiesack
Copy link

Update package dependencies. Remove index.js to generate site (obsolete)
and do so with metalsmith CLI and metalsmith.json.

Update src to use Markdown (not HTML source),
and update links to link to the generated *.html files.
Make the links relative so you can preview file: pages in the browser

Update package dependencies. Remove index.js to generate site (obsolete)
and do so with `metalsmith` CLI and `metalsmith.json`.

Update `src` to use Markdown (not HTML source),
and update links to link to the generated `*.html` files.
Make the links relative so you can preview file: pages in the browser
@coveralls
Copy link

coveralls commented Aug 1, 2018

Coverage Status

Coverage remained the same at 96.875% when pulling bacfb63 on DavidBiesack:feature/static-site into 82a00bf on segmentio:master.

@ismay
Copy link

ismay commented Aug 2, 2018

Cool, thanks for the PR 😊! I'm thinking that it might be good if we just delete the examples altogether actually. Keeping these both these examples as well as the wikis on layouts and in-place up-to-date seems prone to errors.

I personally think it would be better, and less confusing to newcomers to just have the examples in one place. What do you think @Ajedi32 ?

@DavidBiesack
Copy link
Author

As a user, I prefer actual git repos and real source code over wikis examples. The wiki examples are harder to use, as one must copy/paste more commands (multiple npm install .... commands), copy/paste code/files, vs. just npm install && npm run build.
However, if the metalsmith readme points to accurate, working examples and removes broken ones, this will help new users (as is, the metalsmith readme does not even mention metalsmith-in-place).

@Ajedi32
Copy link
Member

Ajedi32 commented Aug 3, 2018

As @DavidBiesack says, having examples in git that you can easily clone and run is valuable. They do have a tendency to get out of date though, which makes them much less useful than they otherwise could be. I previously proposed #208 as a possible solution to that problem.

Perhaps the Metalsmith core repo isn't the best place for these sort of projects. It'd be nice if we could move those a place more focused on documentation, but I'm not really sure where.

@ismay
Copy link

ismay commented Aug 3, 2018

They do have a tendency to get out of date though, which makes them much less useful than they otherwise could be.

I think it’s also complicated because the examples use plugins which aren’t a part of this repo.

Perhaps the Metalsmith core repo isn't the best place for these sort of projects. It'd be nice if we could move those a place more focused on documentation

I think that that’s better. Currently documentation is too fragmented in my opinion. I’d completely forgotten that these examples were in the core repo for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants