Query validator FE #47098
Merged
Query validator FE #47098
680
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npfitz
force-pushed
the
query-validator
branch
from
ed6553a
to
1f9b389
Compare
enterprise/frontend/src/metabase-enterprise/troubleshooting/utils.ts
Outdated
Show resolved
Hide resolved
enterprise/frontend/src/metabase-enterprise/troubleshooting/index.tsx
Outdated
Show resolved
Hide resolved
enterprise/frontend/src/metabase-enterprise/troubleshooting/components/QueryValidator.tsx
Outdated
Show resolved
Hide resolved
npfitz
force-pushed
the
query-validator
branch
from
add1f01
to
99dd99e
Compare
npfitz
force-pushed
the
query-validator
branch
2 times, most recently
from
7718fad
to
b0fa4dc
Compare
npfitz
force-pushed
the
query-validator
branch
from
b0fa4dc
to
5162d16
Compare
| @@ -0,0 1,19 @@ | |||
| import { Api } from "metabase/api"; | |||
There was a problem hiding this comment.
Use the EnterpriseApi instead
| if (messages.length > 0) { | ||
| return messages.join(", "); | ||
| } else { | ||
| return "I don't know what's wrong, but it's broken"; |
There was a problem hiding this comment.
Translate probably pick something more Metabase-y sounding 😅
Comment on lines
34
to
36
| const errorTypes = Object.keys( | ||
| ERROR_DICTIONARY, | ||
| ) as (keyof typeof ERROR_DICTIONARY)[]; |
There was a problem hiding this comment.
two minor nits
- this can be moved out of this function so it's only done once
- i think using _.keys will do the same without having to do the typecasting
sloansparger
requested changes
Aug 28, 2024
npfitz
force-pushed
the
query-validator
branch
from
3c8620d
to
bfd6935
Compare
qnkhuat
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Query Validator FE * collection path, unit tests * wrapping feature with token flag * updating util function, adding row type * updating session_test.clj * type adjustment * fixing other table sorting * Empty state, clean up utils * unit test adjustment * e2e adjustment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45546
Depends on https://github.com/metabase/harbormaster/issues/5156
Description
Adds a UI for the Query Field Validation Feature. This will display queries with broken data references in a table under
Admin -> Troubleshooting -> Query Validation.How to verify
The easiest way to create an invalid card is to do so via SQL Queries. Go to New -> SQL Query and type
Select foo from Orders. Save the card, then go toAdmin -> Troubleshooting -> Query Validation. Your card should be present.Demo
(pretend creator is populated above)
Checklist