-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uchardet] Add ability to disable building tests #1559
Comments
The entire testsuite is a single C file with zero dependencies. What would an option even do? |
This option would skip building this single C file with zero dependencies. Some people don't want to remember complex commands that exclude subprojects tests and may want to do |
So instead they need to remember complex commands that exclude subprojects test options and may want to do What's the difference? |
It is common practice to disable tests with Also if you run EDIT: As for the usecase, I disable unneeded things from build in OSS-Fuzz. I can disable tests from mpv, libplacebo, harfbuzz, fontconfig, fribidi, they all support this argumentand only uchardet left. |
It's a standard convention to have a tests option for disabling the lookup of test dependencies, as it prevents setting up a build at all, if you don't need to run tests and don't have the test dependencies. It's also often used as a workaround for the fact that meson currently builds tests as part of My personal opinion is that the cost/benefit ratio here isn't favorable.
That sounds quite bad since tests are supposed to pass when testing the wrap itself as part of the WrapDB CI. |
As title says, would be nice to disable building tests, if not required.
or
Thanks
The text was updated successfully, but these errors were encountered: