Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaderboard does not show all wallets #404

Open
disifi opened this issue Oct 29, 2018 · 1 comment
Open

Leaderboard does not show all wallets #404

disifi opened this issue Oct 29, 2018 · 1 comment
Labels
CLI merit-cli issues daemon meritd issues Hacktoberfest

Comments

@disifi
Copy link

disifi commented Oct 29, 2018

Describe the issue

Leaderboard shows only one wallet on each place. If more wallets have same score, only one of them can be found in leaderboard.

Can you reliably reproduce the issue?

On block 436122 like this:

  1. find zero balance wallet e.g. MRBNdavWcoRsE6DP9VzSA4qrtfNs25sEP8
  2. check rank of the wallet with getaddressrank '{"addresses": ["MRBNdavWcoRsE6DP9VzSA4qrtfNs25sEP8"]}' (13184 now on this block)
  3. run getaddressleaderboard 20000 to show whole leaderboard
  4. check 13184th place, there is another wallet (MNPd1JPUdEeykEWaygboKjiyRg1fJ58Zr8 now)

Expected behaviour

I would expect to find my wallet in leaderboard.

Actual behaviour

My wallet is eventually not found in leaderboard if it's on the same place as some other wallet.

What version of merit-core are you using?

0.7.0
@adilwali
Copy link
Contributor

@disifi Thanks for reporting this. I'm sorry for the delay in addressing the issue. We have plans to improve the leaderboard functionality, but it's not part of our near-term roadmap.

I'll keep you posted here.

@eugene-sy eugene-sy added CLI merit-cli issues daemon meritd issues labels Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLI merit-cli issues daemon meritd issues Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adilwali @eugene-sy @disifi