fn decomp_tx: Do not zero txa before initialization
#1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
reviewed
Jun 28, 2024
kkysen
requested changes
Jun 28, 2024
rinon
changed the base branch from
sjc/get_lo_ctx/simplify
to
sjc/tilestatecontext_locking
kkysen
reviewed
Jun 28, 2024
kkysen
reviewed
Jun 28, 2024
rinon
force-pushed
the
sjc/performance
branch
2 times, most recently
from
293dfe8
to
240c45b
Compare
rinon
force-pushed
the
sjc/tilestatecontext_locking
branch
from
3f37ee7
to
9d18014
Compare
rinon
force-pushed
the
sjc/performance
branch
2 times, most recently
from
c13ec52
to
c241b2d
Compare
rinon
force-pushed
the
sjc/tilestatecontext_locking
branch
from
9d18014
to
c71a595
Compare
rinon
force-pushed
the
sjc/tilestatecontext_locking
branch
from
c71a595
to
bd8ac77
Compare
|
AFAICT this is the single biggest potential perf win in rav1d. |
kkysen
requested changes
Jun 30, 2024
rinon
force-pushed
the
sjc/tilestatecontext_locking
branch
from
bd8ac77
to
2506ce8
Compare
rinon
force-pushed
the
sjc/performance
branch
2 times, most recently
from
d46f282
to
8b45876
Compare
|
In my testing, it looks like the latest version with less unsafe is equivalent to the unsafe pointer writes with the assert bounds check. Commenting that assert out gains a tiny bit on my i7-1260p, but seems equivalent on my Zen 4 7700X. |
randomPoison
reviewed
Jul 1, 2024
kkysen
requested changes
Jul 2, 2024
kkysen
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some complexity, but it improved performance significantly, especially on intel. Zeroing an entire page of stack with
memset(which is what was previously happening) is expensive.