Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cascading Bugs in Huggingface and Ollama Embedder #1574

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on Jul 23, 2024

  1. Update huggingface.py

    kmitul committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    de3be68 View commit details
    Browse the repository at this point in the history
  2. Update ollama.py

    kmitul committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    09eb219 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    79deae1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    900ae26 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Update configs.py

    Added 'huggingface' to the provider checklist in validate_config method of EmbedderConfig class
    kmitul committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1028095 View commit details
    Browse the repository at this point in the history
  2. Update huggingface.py

    Renamed get_embedding method to embed
    kmitul committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f13f45a View commit details
    Browse the repository at this point in the history
  3. Update huggingface.py

    Added `dims` attribute to `HuggingFaceEmbedding` using `get_sentence_embedding_dimension` method of `SentenceTransformer`
    kmitul committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    95635fa View commit details
    Browse the repository at this point in the history