Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): incorrect onValueCommitted calls #1218

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(slider): incorrect onValueCommitted calls #1218

merged 2 commits into from
Jun 26, 2024

Commits on Jun 1, 2024

  1. fix(slider): onValueCommitted called only if was active 

    This is a small bug/edge case that was introduced with the addition of
`onValueCommitted` in melt-ui#1212. I basically discovered the problem when I
was using a `select` within a `Slider`, that the `select` component
would not open since the state was being updated due to incorrect
`onValueCommitted` calls.
With this fix, we ensure that `onValueCommitted` is only called when the
`Slider` was actually active, meaning that the `onmousedown` was called
in one of the thumbs of the `Slider`.
    @mikededo
    mikededo committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    d95aca2 View commit details
    Browse the repository at this point in the history

  2. chore: add changeset

    @mikededo
    mikededo committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    c3c46a8 View commit details
    Browse the repository at this point in the history