fix(slider): incorrect onValueCommitted calls
#1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small bug/edge case that was introduced with the addition of `onValueCommitted` in melt-ui#1212. I basically discovered the problem when I was using a `select` within a `Slider`, that the `select` component would not open since the state was being updated due to incorrect `onValueCommitted` calls. With this fix, we ensure that `onValueCommitted` is only called when the `Slider` was actually active, meaning that the `onmousedown` was called in one of the thumbs of the `Slider`.
🦋 Changeset detectedLatest commit: c3c46a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a small bug/edge case that was introduced with the addition of
onValueCommittedin #1212. I basically discovered the problem when I was usinga
selectwithin aSlider, that theselectcomponent would not open sincethe state was being updated due to incorrect
onValueCommittedcalls.With this fix, we ensure that
onValueCommittedis only called when theSliderwas actually active, meaning that theonmousedownwas called in oneof the thumbs of the
Slider.