Feat: add new preventTextSelectionOverflow prop
#1170
Conversation
🦋 Changeset detectedLatest commit: 388886b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anatolzak
changed the title
preventTextSelectionOverflow proppreventTextSelectionOverflow prop
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
Part of me wonders when this would be desired if you're using the floating element in a "modal" fashion (close on outside click, etc.). I suppose since we don't have a source of truth of whether the box is acting as a modal or not having another prop makes sense. I do feel like the default for this should align with the default of the other "close on escape" / "close on outside click" where if we default the builder to act as a modal, this should default to |
For anyone reading, Hunter thought that I was proposing setting |
anatolzak
deleted the
fix/prevent-text-selection-outside-floating-element
branch
closes #1168
Currently, when initiating text selection from within a floating element and dragging the pointer outside, the text outside the floating element gets selected.
This PR introduces a new prop
preventTextSelectionOverflowthat controls whether text-selection overflow is allowed. By defaultpreventTextSelectionOverflowwill betrue.The affected builders are:
Link preview already implemented preventing text-selection overflow, so now the link preview builder gets this behavior from
usePopperlike the other builders mentioned above.Tooltip, however, is not added in this PR because the tooltip closes when the pointer leaves the grace zone. The link preview has logic to prevent closing when text selection occurred. In a later PR, I will merge a lot of the behaviors of the tooltip and link preview, at which point tooltip will inherit the prevention of text-selection overflow and not close itself after the pointer leaves after text selection.
Also, the dialog is not added in this PR because the overlay already takes care of not allowing user selection because the overlay spans the entire viewport.
I haven't added tests yet because I am not sure how you would test this behavior without bending backwards
Here are videos showing all the affected builders before and after.
Context menu
context.menu.mov
Dropdown menu
dropdown.menu.mov
Link preview - same behavior as before
link.preview.mov
Combobox
combobox.mov
Select
select.mov
Menubar
menubar.mov
Popover
popover.mov