Fix: tooltip closes while pointer is still inside trigger #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4aad946 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
huntabyte
approved these changes
Apr 6, 2024
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
TGlide
approved these changes
Apr 21, 2024
This was referenced Apr 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #886
The reason issue #886 occurs is because
clientXis smaller by 1 thantriggerRect.left, which causes us to inaccurately "think" that the pointer is outside the trigger which causes the tooltip to close. This is due to sub-pixel rendering and rounding issues by the browser.To make sure this doesn't happen, we now keep track of 2 extra variables
isPointerInsideTriggerandisPointerInsideContentthat are set onpointerenterandpointerleavefor the trigger and content respectively. AndisPointerInsideTriggerandisPointerInsideContentare taken into account in addition topointInPolygon()when deciding whether the pointer is inside the tooltip area.Before
Screen.Recording.2024-04-06.at.3.23.50.PM.mov
After
Screen.Recording.2024-04-06.at.3.22.58.PM.mov