Feat: add autoSort option for sliders
#1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e95e946 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bennymi
changed the title
disableSwap option for sliders
|
I suggest we name the prop |
Agreed on the clarity of "swap". Even simplifying it to |
bennymi
changed the title
disableSwap option for slidersautoSort option for sliders
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This was referenced Apr 15, 2024
Merged
lolcabanon
pushed a commit
to lolcabanon/melt-ui
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1122.
I added a
disableSwapoption to sliders which disables the automatic ordering of the value array. Therefore it's now possible to have arrays like these:[25, 20, 30], whereas before the value arrays were always automatically sorted. This is important because in some instances users might want indexes to hold specific meaning, so if the values get swapped around there's no way of keeping track of the individual values.I also added an example for it, which demonstrates the different behaviors:
