fix(dialog,popover): restore focus when open set to false
#1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d58ea38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
@huntabyte I added an options parameter to |
huntabyte
changed the title
open to falseopen set to false
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1109
We now restore focus to the trigger (or using the
closeFocusprop) in aneffectthat runs whenopenisfalse. In order to not focus the trigger on initial mount whenopenisfalse, I added a parameterskipFirstRunto theeffectfunction that optionally skips the first run of the effect.I also added regression tests for the dialog and popover.
Also, in the menu builder, we are already doing what I implemented with the dialog and popover, which removes the need in the menu builder to manually focus the trigger in multiple places. And I cleaned up the effect in the menu component.
Dialog Before
Screen.Recording.2024-03-20.at.1.58.50.PM.mov
Dialog After
Screen.Recording.2024-03-20.at.1.59.18.PM.mov
Popover Before
Screen.Recording.2024-03-20.at.1.41.15.PM.mov
Popover After
Screen.Recording.2024-03-20.at.1.42.38.PM.mov