refactor menu #1056
Merged
refactor menu #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ee3c9e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
TGlide
approved these changes
Apr 15, 2024
This was referenced Apr 15, 2024
Merged
lolcabanon
pushed a commit
to lolcabanon/melt-ui
that referenced
this pull request
Apr 20, 2024
Co-authored-by: Thomas G. Lopes <26071571 [email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu Refactor:
rootActiveTriggerin trigger action (when trigger mounts) instead of insafeOnMountand ineffect([rootOpen, preventScroll])subActiveTriggerin subTrigger action (when subTrigger mounts) instead of insafeOnMountand in subTriggerclickhandler and in subTriggerkeydownhandlereffect([rootOpen])and using early return for cleaner code