Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor context menu #1054

Merged
merged 6 commits into from
Apr 15, 2024
Merged

refactor context menu #1054

merged 6 commits into from
Apr 15, 2024

Conversation

anatolzak
Copy link
Contributor

@anatolzak anatolzak commented Mar 4, 2024 •
edited
Loading

Context Menu Refactor:

  • using isElement helper
  • setting rootActiveTrigger in trigger action instead of in handleOpen
  • using nullish coalescing operator

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 42f7807

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@melt-ui/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@huntabyte
Copy link
Member

This PR will get similar feedback as #1055 - the activeTrigger needs to remain composable. By setting it in the action we aren't able to use an element not using the action as an active trigger.

@TGlide
Copy link
Member

TGlide commented Mar 26, 2024

This PR will get similar feedback as #1055 - the activeTrigger needs to remain composable. By setting it in the action we aren't able to use an element not using the action as an active trigger.

Why not? If that's the goal, then we need to expose the activeTrigger store, which we currently do not. And even then, it shouldn't be an impediment, right?

If you agree, feel free to merge this later :)

@TGlide
Copy link
Member

TGlide commented Apr 15, 2024

@anatolzak could you solve the conflicts?

@anatolzak
Copy link
Contributor Author

anatolzak commented Apr 15, 2024 •
edited
Loading

@anatolzak could you solve the conflicts?

@TGlide done :)

@TGlide TGlide merged commit 9d684a2 into melt-ui:develop Apr 15, 2024
5 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
@anatolzak anatolzak deleted the refactor/context-menu branch April 15, 2024 11:39
This was referenced Apr 15, 2024
Open
Open
Open
lolcabanon pushed a commit to lolcabanon/melt-ui that referenced this pull request Apr 20, 2024
@anatolzak @TGlide @lolcabanon
refactor context menu (melt-ui#1054)
80cb524 
Co-authored-by: Thomas G. Lopes <26071571 [email protected]>
@patooworld patooworld mentioned this pull request May 29, 2024
Open
@patooworld patooworld mentioned this pull request Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TGlide TGlide TGlide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anatolzak @huntabyte @TGlide