[link preview] fix content showing up at top left after remounting trigger #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b78ce2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anatolzak
changed the title
TGlide
approved these changes
Mar 26, 2024
Merged
This was referenced Mar 28, 2024
lolcabanon
pushed a commit
to lolcabanon/melt-ui
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1060
setting
activeTriggerin trigger action (when trigger is mounted) instead of insafeOnMount. This makes sure that we always have a reference to the up-to-date trigger every time a new trigger mounts. Currently, if you just unmount the trigger and remount it, we have a staleactiveTriggerwhich breaks the behavior of the component as seen in the mentioned issue aboveBefore
Screen.Recording.2024-03-05.at.1.40.20.PM.mov
After
Screen.Recording.2024-03-05.at.2.44.10.PM.mov