Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focus trap] focus trap deactivates on an intercepted outside interaction #1134

Closed
anatolzak opened this issue Mar 29, 2024 · 0 comments · Fixed by #1135 or #1126 · May be fixed by patooworld/novel#3
Closed

[Focus trap] focus trap deactivates on an intercepted outside interaction #1134

anatolzak opened this issue Mar 29, 2024 · 0 comments · Fixed by #1135 or #1126 · May be fixed by patooworld/novel#3
Labels
bug Something isn't working

Comments

@anatolzak
Copy link
Contributor

Describe the bug

When using a dialog for example with an element that intercepts an outside interaction, when triggering the outside interaction that gets intercepted, the dialog doesn't close as expected, however the focus trap deactivates which is not the expected behavior.

Screen.Recording.2024-03-29.at.1.48.50.PM.mov

Reproduction

This issue was brought to life after #1114 got merged which allowed to intercept an outside interaction which previously was impossible. Since we have not released a new version of the package, this issue is not reproducible unless testing it locally.

Logs

No response

System Info

see above comment about reproduction

Severity

annoyance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant