fix(slider): incorrect onValueCommitted calls (#1218)

melt-ui · Jun 26, 2024 · f924049 · f924049
1 parent 65b6ea2
commit f924049
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/fifty-suits-reflect.md b/.changeset/fifty-suits-reflect.md
@@ -0,0 1,5 @@
 ---
 '@melt-ui/svelte': patch
 ---
 
 fix(slider): `onValueCommitted` called if the slider had an active state
diff --git a/src/lib/builders/slider/create.ts b/src/lib/builders/slider/create.ts
@@ -521,11 521,11 @@ export const createSlider = (props?: CreateSliderProps) => {
  };
 
  const pointerUp = () => {
- isActive.set(false);
-
- if (withDefaults?.onValueCommitted) {
  if (withDefaults?.onValueCommitted && isActive.get()) {
  withDefaults.onValueCommitted(value.get());
  }
 
  isActive.set(false);
  };
 
  const unsub = executeCallbacks(