Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi select #5643

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Support multi select #5643

merged 7 commits into from
Dec 10, 2024

Conversation

techdavidy
Copy link
Contributor

@techdavidy techdavidy commented Dec 9, 2024

fixes #1938

Screenshot 2024-12-09 at 11 48 39 AM

@techdavidy techdavidy requested a review from a team as a code owner December 9, 2024 20:22
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 0:28am
medplum-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 0:28am
medplum-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 0:28am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medplum-www ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 0:28am

Copy link
Member

@mattlong mattlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion

@@ -436,6 472,14 @@ function isDropDownChoice(item: QuestionnaireItem): boolean {
);
}

function isMultiSelectChoice(item: QuestionnaireItem): boolean {
return !!item.extension?.some(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getExtensionValue helper could be useful here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was doing some testing but left as is to keep it consistent with the rest of the file

@techdavidy techdavidy added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 96d12f8 Dec 10, 2024
33 checks passed
@techdavidy techdavidy deleted the david-multi-select branch December 10, 2024 18:55
@reshmakh reshmakh added this to the December 31, 2024 milestone Dec 10, 2024
ianplunkett pushed a commit that referenced this pull request Dec 11, 2024
* first commit

* Enable multi select

* roll back drop-down

* [autofix.ci] apply automated fixes

* test

* test for empty data

---------

Co-authored-by: David Yanez <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586 autofix-ci[bot]@users.noreply.github.com>
medplumbot added a commit that referenced this pull request Dec 14, 2024
## What's Changed

* docs(react-hooks): fix link description text (#5612)
* Preserve sort order for chained search using implicit joins (#5513)
* Use exponential backoff for bot deploy retries (#5618)
* Fsh (FHIR Shorthand) example (#5617)
* Fix markdown formatting on binary-data page (#5521)
* Helm & Terraform Deployment for Medplum app on GCP (#5390)
* Fixes #5616 - replace add/save buttons on search filter editor (#5620)
* Split config settings table into full sections (#5619)
* Add support for enableWhenExpression (#5624)
* Log verbose warning on database statement timeout (#5626)
* Do not fetch client info when client_id is medplum-cli (#5635)
* Disambiguate code column in $expand SQL (#5637)
* Client-side filtering in requestSchema to avoid loading  extra SDs (#5638)
* Address vscode vitest extension errors (#5639)
* Docs: Fixes invalid TS syntax for reverse chained search (#5628)
* Conditionally show DoseSpot icon in medplum-provider (#5623)
* feat(server): add super admin table settings route (#5633)
* Dependency upgrades 2024-12-09 (#5640)
* Support multi select (#5643)
* S3 Native Presigned URLs (#5445)
* Make AuditEventActionLookup exhaustive (#5652)
* Error in Heading caused sidebar issue migration-pipelines.md (#5650)
* Add defaultHeaders optional parameter for MedplumClient Constructor (#5653)
* Use transaction for If-Match check (#5647)
* Enhance audit logs with resource reference and interaction duration (#5649)
* feat(server): add logging for each seed step and duration (#5655)
* Add counter metric for FHIR interactions (#5656)
* docs: Add Multi-Tenant Access Control Implementation Guide (#5621)
* Fix metrics for interaction duration and count (#5659)
* feat(server): log more stats per table, allow tables to be specified (#5662)
* Fixes #5663 - add inner types to base-schema.json (#5665)
* Add sw operator to _filter search (#5666)
* Allow applying slice to singleton elements (#5661)
* Version policy doc (#5670)
* Remove note about _filter not supporting chained search (#5667)
* Questionnaire Builder preserve  whitespace in question (#5648)
* Added NDC constant (#5671)

**Full Changelog**: v3.2.24...v3.2.25
github-merge-queue bot pushed a commit that referenced this pull request Dec 14, 2024
## What's Changed

* docs(react-hooks): fix link description text (#5612)
* Preserve sort order for chained search using implicit joins (#5513)
* Use exponential backoff for bot deploy retries (#5618)
* Fsh (FHIR Shorthand) example (#5617)
* Fix markdown formatting on binary-data page (#5521)
* Helm & Terraform Deployment for Medplum app on GCP (#5390)
* Fixes #5616 - replace add/save buttons on search filter editor (#5620)
* Split config settings table into full sections (#5619)
* Add support for enableWhenExpression (#5624)
* Log verbose warning on database statement timeout (#5626)
* Do not fetch client info when client_id is medplum-cli (#5635)
* Disambiguate code column in $expand SQL (#5637)
* Client-side filtering in requestSchema to avoid loading  extra SDs (#5638)
* Address vscode vitest extension errors (#5639)
* Docs: Fixes invalid TS syntax for reverse chained search (#5628)
* Conditionally show DoseSpot icon in medplum-provider (#5623)
* feat(server): add super admin table settings route (#5633)
* Dependency upgrades 2024-12-09 (#5640)
* Support multi select (#5643)
* S3 Native Presigned URLs (#5445)
* Make AuditEventActionLookup exhaustive (#5652)
* Error in Heading caused sidebar issue migration-pipelines.md (#5650)
* Add defaultHeaders optional parameter for MedplumClient Constructor (#5653)
* Use transaction for If-Match check (#5647)
* Enhance audit logs with resource reference and interaction duration (#5649)
* feat(server): add logging for each seed step and duration (#5655)
* Add counter metric for FHIR interactions (#5656)
* docs: Add Multi-Tenant Access Control Implementation Guide (#5621)
* Fix metrics for interaction duration and count (#5659)
* feat(server): log more stats per table, allow tables to be specified (#5662)
* Fixes #5663 - add inner types to base-schema.json (#5665)
* Add sw operator to _filter search (#5666)
* Allow applying slice to singleton elements (#5661)
* Version policy doc (#5670)
* Remove note about _filter not supporting chained search (#5667)
* Questionnaire Builder preserve  whitespace in question (#5648)
* Added NDC constant (#5671)

**Full Changelog**: v3.2.24...v3.2.25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Support multiple selections in QuestionnaireForm drop-downs
3 participants