Pre-process deb app config settings #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
reshmakh
approved these changes
Dec 1, 2024
Merged
medplumbot
added a commit
that referenced
this pull request
Dec 2, 2024
## What's Changed * Add automatic retry of transaction serialization errors after rollback (#5553) * Document resend operation parameters (#5556) * Script to deploy app to GCP (#5505) * Document extensions for preferred pharmacy (#5557) * feat(server): add `Bot.timeout`, sync timeout on `Bot/$deploy` (#5559) * Include AHC HRSN Screening to foomedical (#5564) * Docs for install on GCP (#5563) * types(generator): validate `fhirtypes` after generation (#5544) * Fix grammar error on scheduling index. (#5569) * Allow cancellation of reindex job (#5565) * fix(AsyncJob): use `systemRepo` for cancel (#5577) * Add excluded IDs to search pagination cursor (#5582) * Add Postgres upgrade blog post (#5547) * feat(AsyncJob): support `AsyncJob` cancel via DELETE on `Content-Location` (#5587) * Update grammar on homepagecallout component (#5570) * Correct oauth2 default paths (#5591) * Show only one offline notification at a time (#5583) * overflow wrap (#5574) * Use strict equality check in tests (#5595) * Update to include how to test agent in docker (#5598) * Update index.md (#5596) * Dependency upgrades 2024-11-25 (#5588) * Fixes #5590 - cleanup default URLs in server config (#5592) * Fix CPOE acronym (#5571) * Rename "Solutions Engineer" to "Forward Deployed engineer" (#5600) * Fixed APT repository codenames (#5605) * Fix the deb app nginx config (#5606) * Fix app config settings in deb package (#5607) * Pre-process deb app config settings (#5608) * OAuthPage UI customizations (#5601) * deps(server): override `whatwg-url` to rm `punycode` warning (#5611) * Dependency upgrades 2024-12-02 (#5609) * fix(core): allow raw buf and views in arrayBuffer fns (#5599) * Migration generation improvements (#5589) **Full Changelog**: v3.2.23...v3.2.24
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
## What's Changed * Add automatic retry of transaction serialization errors after rollback (#5553) * Document resend operation parameters (#5556) * Script to deploy app to GCP (#5505) * Document extensions for preferred pharmacy (#5557) * feat(server): add `Bot.timeout`, sync timeout on `Bot/$deploy` (#5559) * Include AHC HRSN Screening to foomedical (#5564) * Docs for install on GCP (#5563) * types(generator): validate `fhirtypes` after generation (#5544) * Fix grammar error on scheduling index. (#5569) * Allow cancellation of reindex job (#5565) * fix(AsyncJob): use `systemRepo` for cancel (#5577) * Add excluded IDs to search pagination cursor (#5582) * Add Postgres upgrade blog post (#5547) * feat(AsyncJob): support `AsyncJob` cancel via DELETE on `Content-Location` (#5587) * Update grammar on homepagecallout component (#5570) * Correct oauth2 default paths (#5591) * Show only one offline notification at a time (#5583) * overflow wrap (#5574) * Use strict equality check in tests (#5595) * Update to include how to test agent in docker (#5598) * Update index.md (#5596) * Dependency upgrades 2024-11-25 (#5588) * Fixes #5590 - cleanup default URLs in server config (#5592) * Fix CPOE acronym (#5571) * Rename "Solutions Engineer" to "Forward Deployed engineer" (#5600) * Fixed APT repository codenames (#5605) * Fix the deb app nginx config (#5606) * Fix app config settings in deb package (#5607) * Pre-process deb app config settings (#5608) * OAuthPage UI customizations (#5601) * deps(server): override `whatwg-url` to rm `punycode` warning (#5611) * Dependency upgrades 2024-12-02 (#5609) * fix(core): allow raw buf and views in arrayBuffer fns (#5599) * Migration generation improvements (#5589) **Full Changelog**: v3.2.23...v3.2.24
ianplunkett
pushed a commit
that referenced
this pull request
Dec 11, 2024
ianplunkett
pushed a commit
that referenced
this pull request
Dec 11, 2024
## What's Changed * Add automatic retry of transaction serialization errors after rollback (#5553) * Document resend operation parameters (#5556) * Script to deploy app to GCP (#5505) * Document extensions for preferred pharmacy (#5557) * feat(server): add `Bot.timeout`, sync timeout on `Bot/$deploy` (#5559) * Include AHC HRSN Screening to foomedical (#5564) * Docs for install on GCP (#5563) * types(generator): validate `fhirtypes` after generation (#5544) * Fix grammar error on scheduling index. (#5569) * Allow cancellation of reindex job (#5565) * fix(AsyncJob): use `systemRepo` for cancel (#5577) * Add excluded IDs to search pagination cursor (#5582) * Add Postgres upgrade blog post (#5547) * feat(AsyncJob): support `AsyncJob` cancel via DELETE on `Content-Location` (#5587) * Update grammar on homepagecallout component (#5570) * Correct oauth2 default paths (#5591) * Show only one offline notification at a time (#5583) * overflow wrap (#5574) * Use strict equality check in tests (#5595) * Update to include how to test agent in docker (#5598) * Update index.md (#5596) * Dependency upgrades 2024-11-25 (#5588) * Fixes #5590 - cleanup default URLs in server config (#5592) * Fix CPOE acronym (#5571) * Rename "Solutions Engineer" to "Forward Deployed engineer" (#5600) * Fixed APT repository codenames (#5605) * Fix the deb app nginx config (#5606) * Fix app config settings in deb package (#5607) * Pre-process deb app config settings (#5608) * OAuthPage UI customizations (#5601) * deps(server): override `whatwg-url` to rm `punycode` warning (#5611) * Dependency upgrades 2024-12-02 (#5609) * fix(core): allow raw buf and views in arrayBuffer fns (#5599) * Migration generation improvements (#5589) **Full Changelog**: v3.2.23...v3.2.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx
sub_filteronly supports one search/replace operation per request. You can't chain them together.There's an unofficial 3rd party nginx extension that would support it (https://github.com/yaoweibin/ngx_http_substitutions_filter_module) but it has a ton of security implications, so I'm going to punt on that one for now.
Instead, this PR pre-processes the config settings directly into the
.jsfiles.Pros: it works, faster, less complicated
Cons: this makes it harder to change config settings later, and will basically require a re-install of
app. I think that's ok for now, we still have a lot of details to figure out here.