Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bower.json lists multiple files of the same filetype for "main" option #227

Closed
bradleyayers opened this issue Jun 30, 2015 · 11 comments
Closed

bower.json lists multiple files of the same filetype for "main" option #227

bradleyayers opened this issue Jun 30, 2015 · 11 comments

Comments

@bradleyayers
Copy link

https://github.com/bower/bower.json-spec#main explicitly states that only one file per filetype should be listed in main:

The entry-point files necessary to use your package. Only one file per filetype.

"main": [
  "src/URI.js",
  "src/IPv6.js",
  "src/SecondLevelDomains.js",
  "src/punycode.js",
  "src/URITemplate.js",
  "src/jquery.URI.js",
  "src/URI.min.js",
  "src/jquery.URI.min.js",
  "src/URI.fragmentQuery.js",
  "src/URI.fragmentURI.js"
],

I would expect only one .js file here.
@AntoineReneleau
Copy link

👍
Same issue here, I only need URI.min.js and all the others modules and jQuery are installed by Bower.

@bradleyayers
Copy link
Author

The documentation also states:

Do not include minified files.

So we want to only include src/URI.js rather than src/URI.min.js.

@AntoineReneleau
Copy link

My bad, src/URI.js will do just fine.

@AntoineReneleau AntoineReneleau mentioned this issue Jun 30, 2015
Closed
2 tasks
rodneyrehm added a commit that referenced this issue Jun 30, 2015
@rodneyrehm
feature(package): bower.main must be a single JS file, closes #227
1faeae1
@rodneyrehm
Copy link
Member

… and it's in master as well…

@AntoineReneleau
Copy link

Thanks a lot ! When can we expect a release for that ?

@rodneyrehm
Copy link
Member

right now I'd make that depend on @bradleyayers' testing efforts. if he thinks he's done and no more issues pop up, I'm happy to release 1.15.2 - but I'd not want to release that, just to see him raise more issues hours later ;)

@AntoineReneleau
Copy link

Ok.
Another question : should the lib still depends on jQuery since the jQuery plugin isn't anymore in bower.json ?

@rodneyrehm
Copy link
Member

hm… it probably shouldn't. The jQuery binding should probably be moved to a separate repository… :/

rodneyrehm added a commit that referenced this issue Jun 30, 2015
@rodneyrehm
feature(package): removing jQuery from dependencies, because it is no…
199b9b6 
…t a hard dependency #227
@bradleyayers
Copy link
Author

I've finished my current stint of testing, so I'm in favour of a new release.

@AntoineReneleau
Copy link

Thanks for your work. Waiting for the release 👍

@AntoineReneleau AntoineReneleau mentioned this issue Jul 1, 2015
Merged
2 tasks
rodneyrehm added a commit that referenced this issue Jul 2, 2015
@rodneyrehm
feature(package): removing jQuery from dependencies, because it is no…
65ce897 
…t a hard dependency #227
rodneyrehm added a commit that referenced this issue Jul 2, 2015
@rodneyrehm
feature(package): removing jQuery from dependencies, because it is no…
924899c 
…t a hard dependency #227
@rodneyrehm
Copy link
Member

v1.15.2 is released. thanks for all the input :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bradleyayers @rodneyrehm @AntoineReneleau