Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new MS Edge logo SVG for BCD #454

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Add new MS Edge logo SVG for BCD #454

merged 1 commit into from
Apr 6, 2020

Conversation

schalkneethling
Copy link

This updates us to the new Edge logo for BCD.

While setting this up(which failed :() I noticed that .env is mentioned in https://github.com/mdn/stumptown-renderer#quickstart but not added to .gitignore and so, I added it here.

Also, when running yarn start everything goes along swimmingly until I get:

File sizes after gzip:

  54.95 KB  build/static/js/2.631995f1.chunk.js
  10.57 KB  build/static/js/main.0b704842.chunk.js
  5.08 KB   build/static/css/main.86e6dd74.chunk.css
  772 B     build/static/js/runtime-main.cea588d5.js
  530 B     build/static/css/2.5df72ff2.chunk.css

The project was built assuming it is hosted at /.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.
You may serve it with a static server:

  npm install -g serve
  serve -s build

Find out more about deployment here:

  bit.ly/CRA-deploy


/Users/schalkneethling/repos/stumptown-renderer/content/scripts/sources.js:10
      throw new Error(`${filepath} does not exist. Not a valid source.`);
            ^
Error: content/files does not exist. Not a valid source.
    at Sources.add (/Users/schalkneethling/repos/stumptown-renderer/content/scripts/sources.js:10:13)
    at Command._action (/Users/schalkneethling/repos/stumptown-renderer/content/index.js:169:15)
    at Command._run (/Users/schalkneethling/repos/stumptown-renderer/node_modules/caporal/lib/command.js:482:40)
    at Program._run (/Users/schalkneethling/repos/stumptown-renderer/node_modules/caporal/lib/program.js:178:16)
    at Program.parse (/Users/schalkneethling/repos/stumptown-renderer/node_modules/caporal/lib/program.js:284:17)
    at Object.<anonymous> (/Users/schalkneethling/repos/stumptown-renderer/content/index.js:236:5)
    at Module._compile (internal/modules/cjs/loader.js:936:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:947:10)
    at Module.load (internal/modules/cjs/loader.js:790:32)
    at Function.Module._load (internal/modules/cjs/loader.js:703:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:999:10)
    at internal/main/run_main_module.js:17:11
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Perhaps something to split into an issue but, thought I would mention it here.

@schalkneethling schalkneethling linked an issue Apr 6, 2020 that may be closed by this pull request
@@ -17,6 17,7 @@
.env.development.local
.env.test.local
.env.production.local
.env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't wrong but I would strongly recommend you add it to your ~/.gitignore_global too so you don't accidentally ever add it on new projects.

@peterbe peterbe closed this Apr 6, 2020
@peterbe peterbe reopened this Apr 6, 2020
@peterbe
Copy link
Contributor

peterbe commented Apr 6, 2020

Trying to restart Travis

@peterbe peterbe merged commit 7ed09cf into mdn:master Apr 6, 2020
@caugner caugner added the browser-compat issues related to the browser compatibility data tables (BCD) label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-compat issues related to the browser compatibility data tables (BCD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New MS Edge logo
3 participants