Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include preferredlocale in "Change language" event #3520

Merged
merged 1 commit into from
Apr 15, 2021
Merged

include preferredlocale in "Change language" event #3520

merged 1 commit into from
Apr 15, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Apr 14, 2021

Part of #3519

Screen Shot 2021-04-14 at 2 32 02 PM

@peterbe peterbe requested a review from schalkneethling April 14, 2021 18:39
schalkneethling
schalkneethling approved these changes Apr 15, 2021
View reviewed changes
Copy link

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@schalkneethling schalkneethling merged commit f2feb19 into mdn:main Apr 15, 2021
@peterbe peterbe deleted the 3519-include-preferredlocale-in-change-language-event branch April 15, 2021 20:11
@peterbe
Copy link
Contributor Author

peterbe commented Apr 16, 2021

Oops! It didn"t work. We need to parse the document.cookie string. What"s being recorded right now on GA are events like:

Change preferred language (cookie before: _ga=GA1.2.1107221010.1606135547; _gid=GA1.2.733322513.1618498176; preferredlocale=ru; lux_uid=161858967062804311; _gat=1)

peterbe added a commit to peterbe/yari that referenced this pull request Jun 1, 2021
@peterbe
include preferredlocale in "Change language" event (mdn#3520)
3a8ba01 
Part of mdn#3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkneethling schalkneethling schalkneethling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbe @schalkneethling