Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS_Ref broken smartlinks #8578

Open
15 tasks
caugner opened this issue Apr 5, 2023 · 2 comments
Open
15 tasks

CSS_Ref broken smartlinks #8578

caugner opened this issue Apr 5, 2023 · 2 comments
Labels
accepting PR We invite you to open a PR to resolve this issue. 🐛 bug Something isn't working, or isn't working as expected effort: small This task is a small effort. idle macros tracking issues related to kumascript macros

Comments

@caugner
Copy link
Contributor

caugner commented Apr 5, 2023

While testing out #8571, Sentry collected the following errors regarding broken smartlinks in the CSS_Ref macro:

In CSS_Ref the smartLink to ... is broken!

  • /en-US/docs/Web/CSS/:host() (redirects to /en-US/docs/Web/CSS/:host_function)
  • /en-US/docs/Web/CSS/:host-context() (does not exist)
  • /en-US/docs/Web/CSS/@font-face/font-feature-settings (does not exist)
  • /en-US/docs/Web/CSS/@font-face/font-variant (redirects to /en-US/docs/Web/CSS/@font-face)
  • /en-US/docs/Web/CSS/@historical-forms (does not exist)
  • /en-US/docs/Web/CSS/@page/bleed (does not exist)
  • /en-US/docs/Web/CSS/an-plus-b (does not exist)
  • /en-US/docs/Web/CSS/block-overflow (does not exist)
  • /en-US/docs/Web/CSS/caret (does not exist)
  • /en-US/docs/Web/CSS/caret-shape (does not exist)
  • /en-US/docs/Web/CSS/conic-gradient (redirects to /en-US/docs/Web/CSS/gradient/conic-gradient)
  • /en-US/docs/Web/CSS/hwb (does not exist)
  • /en-US/docs/Web/CSS/image-set (redirects to /en-US/docs/Web/CSS/image/image-set)
  • /en-US/docs/Web/CSS/input-security (does not exist)
  • /en-US/docs/Web/CSS/single-transition-timing-function#cubic-bezier() (redirects to /en-US/docs/Web/CSS/easing-function)
@caugner caugner added 🐛 bug Something isn't working, or isn't working as expected macros tracking issues related to kumascript macros accepting PR We invite you to open a PR to resolve this issue. labels Apr 5, 2023
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Apr 5, 2023
@caugner
Copy link
Contributor Author

caugner commented Apr 5, 2023

FYI @wbamberg

@wbamberg
Copy link
Collaborator

wbamberg commented Apr 5, 2023

Yeah, this is because CSS_Ref uses mdn/data to get the list of items to include, and the things in mdn/data don't match the actual pages we have.

It would probably be better for CSS_Ref to use what's actually under /CSS, along with page types, to build https://developer.mozilla.org/en-US/docs/Web/CSS/Reference#index. Assuming we think https://developer.mozilla.org/en-US/docs/Web/CSS/Reference#index is useful enough to be worth it, which I doubt.

@mirunacurtean mirunacurtean removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Apr 6, 2023
@github-actions github-actions bot added the idle label Jan 24, 2024
@caugner caugner added the effort: small This task is a small effort. label Jun 24, 2024
@github-actions github-actions bot removed the idle label Jun 24, 2024
@github-actions github-actions bot added the idle label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR We invite you to open a PR to resolve this issue. 🐛 bug Something isn't working, or isn't working as expected effort: small This task is a small effort. idle macros tracking issues related to kumascript macros
Projects
None yet
Development

No branches or pull requests

3 participants