Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mocha-client-tests from using chrome.* to browser.* #165

Closed
kumar303 opened this issue Dec 14, 2016 · 1 comment
Closed

Convert mocha-client-tests from using chrome.* to browser.* #165

kumar303 opened this issue Dec 14, 2016 · 1 comment
Labels
help wanted If you know something about this topic, we would love your help!

Comments

@kumar303
Copy link
Contributor

re: https://github.com/mdn/webextensions-examples/tree/master/mocha-client-tests

The use of the chrome.* API should be converted to browser.*. See: https://mail.mozilla.org/pipermail/dev-addons/2016-October/002025.html

@wbamberg wbamberg added the help wanted If you know something about this topic, we would love your help! label May 9, 2017
zlatin added a commit to zlatin/webextensions-examples that referenced this issue Aug 13, 2017
zlatin added a commit to zlatin/webextensions-examples that referenced this issue Aug 19, 2017
wbamberg pushed a commit that referenced this issue Sep 11, 2017
* convert chrome. to browser. Issue #165

* fix browser-polyfill

* convert chrome.* to browser.* (#166)

* convert chrome.* to browser.*

* change chrome to browser

* change the callback-style to promise-style

* change the callback-style to promise-style
@wbamberg
Copy link

Fixed by #262. Thanks @zlatin !

wbamberg pushed a commit that referenced this issue Sep 12, 2017
…fixes

* origin/master: (26 commits)
  convert chrome. to browser. Issue #165 #166 (#262)
  Update examples.json for contextMenus->menus change (#282)
  Update context-menu-demo (#272)
  change shortcut to Ctrl Shift U for commands example (#264)
  Update `proxy-blocker` extension to be compatible with firefox 56  (#260)
  Update eslint and .travis.yml (#259)
  add in titlePreface (#256)
  Hellosct1 webext (#237)
  Remove 'highlight', as Firefox does not support it (#252)
  Reflect bookmark state in icon title to make it accessible to screen readers (#255)
  Adding listing/descriptions for the imagify and themes examples. (#253)
  Selfify example (#251)
  New theme examples (#248)
  Example: embedded webextension overlay (#249)
  Add an indexedDB file storage example: image-reference-collector (#224)
  webextension -> extension (#250)
  more fields into package.json
  Add travis-ci build status badge
  Add .travis.yml
  more .eslintrc.json and fixes
  ...
wbamberg pushed a commit that referenced this issue Oct 10, 2017
* origin/master: (149 commits)
  Add some icons (#285)
  add in simple http-response example (#281)
  convert chrome. to browser. Issue #165 #166 (#262)
  Update examples.json for contextMenus->menus change (#282)
  Update context-menu-demo (#272)
  change shortcut to Ctrl Shift U for commands example (#264)
  Update `proxy-blocker` extension to be compatible with firefox 56  (#260)
  Update eslint and .travis.yml (#259)
  add in titlePreface (#256)
  Hellosct1 webext (#237)
  Remove 'highlight', as Firefox does not support it (#252)
  Reflect bookmark state in icon title to make it accessible to screen readers (#255)
  Adding listing/descriptions for the imagify and themes examples. (#253)
  Selfify example (#251)
  New theme examples (#248)
  Example: embedded webextension overlay (#249)
  Add an indexedDB file storage example: image-reference-collector (#224)
  webextension -> extension (#250)
  more fields into package.json
  Add travis-ci build status badge
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted If you know something about this topic, we would love your help!
Projects
None yet
Development

No branches or pull requests

2 participants