Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Symbol.species 신규 번역 외 #22388

Closed
wants to merge 5 commits into from

Conversation

wisedog
Copy link
Contributor

@wisedog wisedog commented Jul 13, 2024

  • Symbol.species 신규 번역

다음은 (Commit: 6e93ec8) 중 Symbol 일부 대응.

  • Symbol.prototype[@@toPrimitive]
  • Symbol.prototype.description
  • Symbol.replace
  • Symbol.search
  • Symbol.prototype.toString()

@wisedog wisedog requested a review from a team as a code owner July 13, 2024 04:12
@wisedog wisedog requested review from sunhpark42 and removed request for a team July 13, 2024 04:12
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 13, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 27, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@wisedog
Copy link
Contributor Author

wisedog commented Jul 27, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@hochan222 음 역시 .. 🥲

@hochan222
Copy link
Member

변경되는 시점이 겹쳤군요 🥲🥲

@wisedog
Copy link
Contributor Author

wisedog commented Jul 27, 2024

변경되는 시점이 겹쳤군요 🥲🥲

솔직히 en-US 쪽 Global Object 너무 바꿔대서 좀 질렸습니다. 어쨋든 85%는 맟추기로 했으니 하긴 하는데, 앞으로는 이쪽은 별로 손대고 싶지 않군요.

다음은 (Commit: 6e93ec8) 중 Symbol 일부 대응.

Symbol.prototype[@@toPrimitive]
Symbol.prototype.description
Symbol.replace
Symbol.search
Symbol.prototype.toString()
@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 27, 2024
…s/index.md

Co-authored-by: github-actions[bot] <41898282 github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@sunhpark42 sunhpark42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @wisedog 님 번역내용 확인 했습니다.
스타일 이슈가 있어서 RC 남깁니다. 금일 확인 어려우시면 간단한 부분이라 제가 수정해서 머지하겠습니다. 편히 말씀주세요!

@wisedog
Copy link
Contributor Author

wisedog commented Jul 30, 2024

쓰읍... @hochan222 @sunhpark42 뭔가 린트가 이상합니다.

@wisedog
Copy link
Contributor Author

wisedog commented Jul 30, 2024

해당 PR은 닫고 다시 올리도록 하겠습니다. 같이 봐주셔서 감사합니다. @sunhpark42

@sunhpark42
Copy link
Contributor

sunhpark42 commented Jul 30, 2024

린트가 자꾸 아래로 수정하네요 ㅠㅠ 확인 감사합니다 @wisedog

> [!WARNING] > `Symbol.species`가 존재하면 임의의 코드가 실행될 수 있으며 보안 취약점이 발생할 수 있습니다. 또한 특정 최적화를 훨씬 더 어렵게 만듭니다. 엔진 구현자는 [이 기능을 제거할지 여부를 조사](https://github.com/tc39/proposal-rm-builtin-subclassing)하고 있습니다. 가능하면 이 기능을 사용하지 마세요.

@wisedog
Copy link
Contributor Author

wisedog commented Jul 30, 2024

린트 에러로 인하여 PR을 다시 만들어보겠습니다.

@wisedog wisedog closed this Jul 30, 2024
@wisedog wisedog deleted the js/symbol-species branch August 11, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants