fix: update scale property syntax to add percentage #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
scaleindividual transform property acceptsnumberas well aspercentageas a property value. Updating the syntax here.Motivation
I was using
csstreewhich is consumingmdn-dataas a source to validate. When i was trying to use it's lexer to match the property value forscale. It is throwing error for percentage values. Then started looking around and found the syntax in themdn-dataneeds an update.Additional details
W3 - https://www.w3.org/TR/css-transforms-2/#propdef-scale
MDN - https://developer.mozilla.org/en-US/docs/Web/CSS/scale#values
mdn/content#18269
I have create a repro to quickly check the bug using csstree here.
https://codesandbox.io/p/github/JayaKrishnaNamburu/css-tree-scale-property-bug/main?file=/main.js:12,1&import=true&workspaceId=df6c21a4-866b-4200-a851-bfd2875969d8