Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh-CN to i10n patch 1 #734

Merged
merged 8 commits into from
May 10, 2024
Merged

update zh-CN to i10n patch 1 #734

merged 8 commits into from
May 10, 2024

Conversation

T34-active
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

Copy link
Contributor

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@T34-active T34-active changed the title update zh-CN to i10n update zh-CN to i10n patch 1 Apr 29, 2024
@bsmth
Copy link
Member

bsmth commented May 3, 2024

Thanks for the PR! Is there a description available somewhere so we know the scope of the changes? (will there be a patch 2 or follow-up PRs?)

l10n/css.json Outdated Show resolved Hide resolved
@T34-active
Copy link
Contributor Author

Thanks for the PR! Is there a description available somewhere so we know the scope of the changes? (will there be a patch 2 or follow-up PRs?)谢谢你的公关!是否有可用的描述,以便我们知道更改的范围?(是否会有补丁2或后续公共关系?)

yes, Subsequent possible submission of patch 2

@T34-active T34-active requested a review from bsmth May 3, 2024 07:43
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me when I used machine translation, are you able to get a zh-CN reviewer to have a look, also? Thank you!

@T34-active
Copy link
Contributor Author

OK /cc @yin1999 ,this is zh-CN reviewer

@yin1999
Copy link
Member

yin1999 commented May 4, 2024

Hey @T34-active. Thanks for the translation. Actually, I've finished some translation in my fork (see: yin1999#1). I've reviewed some translation you added in this PR, and felt that some of the translations could be improved by yourself first. For example, unnecessary quantifier translations (e.g. 一个) and unnecessary characters in Chinese (e.g. 绝对长度 - 绝对 <length>, the character is not necessary).

Please do it by yourself first, and ping me again after you think it's ready for review by the l10n-zh team.

Copy link
Contributor Author

@T34-active T34-active left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix content

l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
@T34-active
Copy link
Contributor Author

/cc @yin1999 I fix a few content

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
l10n/css.json Outdated Show resolved Hide resolved
@T34-active T34-active requested review from yin1999 and bsmth May 7, 2024 10:07
@T34-active
Copy link
Contributor Author

It's so hard that I wrote so many parts that basically wrong. just one question, How to find the Formal definition CSS property in JSON? @yin1999 @bsmth

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the zh-CN translation

@yin1999
Copy link
Member

yin1999 commented May 7, 2024

It's so hard that I wrote so many parts that basically wrong. just one question, How to find the Formal definition CSS property in JSON? @yin1999 @bsmth

Search the references of those keys within this repo, or search the English text using Google, or bing, like this: https://www.google.com/search?q="an absolute length; if the keyword none is specified, the computed value is 0" site:developer.mozilla.org&oq="an absolute length; if the keyword none is specified, the computed value is 0" site:developer.mozilla.org

@bsmth
Copy link
Member

bsmth commented May 10, 2024

Thanks a lot! Merging shortly 🚢

@bsmth bsmth merged commit fd3e3ce into mdn:main May 10, 2024
3 checks passed
Copy link
Contributor

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@T34-active T34-active deleted the patch_1 branch May 10, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants