feat(css): add field-sizing property #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
dipikabh
requested changes
Apr 19, 2024
There was a problem hiding this comment.
Hi @chrisdavidmills, I have some concerns about the appliesto value. I'm wondering if it’s worth all the effort to perfect it. What do you think?
css/properties.json
Outdated
| "CSS Basic User Interface" | ||
| ], | ||
| "initial": "normal", | ||
| "appliesto": "textFields", |
There was a problem hiding this comment.
Not sure about this appliesto value.
- Spec says "Applies to: elements with default preferred size"
- We don't have any such value defined for
appliestoin our schema. The closest sounding ones seem to be:"elementsThatAcceptInput"and"elementsForWhichSizeContainmentCanApply"that's been used for contain-intrinsic-size.
Do we need a schema update to add something like "elementsWithDefaultPreferredSize"?
- OTOH, the only other place where
"textFields"has been used iswhich points to an MDN page that does not exist:Line 8632 in 68d18c7
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/ime-mode"
There was a problem hiding this comment.
Yeah, this wasn't great. I've added the suggested value elementsWithDefaultPreferredSize to the schema and the l10n CSS file, and used it for field-sizing.
dipikabh
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chrome 123 supports the
field-sizingproperty, which is used to size textual form elements and textareas by their content, rather than sticking to a fixed size. This PR adds data for the new property.Motivation
Additional details
Related issues and pull requests