Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct animation types #660

Merged
merged 9 commits into from
Apr 13, 2023
Merged

Correct animation types #660

merged 9 commits into from
Apr 13, 2023

Conversation

yarusome
Copy link
Contributor

@yarusome yarusome commented Apr 13, 2023

Description

This PR corrects the animation types for various CSS properties, mainly which were mistaken as "discrete".

Note: During the cleanup:

  1. I found that block-overflow and overflow-clip-box don't exist on either the specs or MDN. Should I detele them?
  2. I also found that point-events has conflicting definitions in Scalable Vector Graphics (SVG) 2 and CSS Basic User Interface Module Level 4. Which one should I align to?
  3. I left the incorrect animation type for overflow-clip-margin intact because there's a spec change between CSS Overflow Module Level 3 and Level 4.

I do think it's important to use webref for automation now, and there should be a way to combine this with community-driven l10n.

Motivation

Additional details

The spec links (sorry for flooding in a single PR 🙏):

Specs Properties
Compatibility Standard touch-action
Compositing and Blending Level 2 (background|mix)-blend-mode, isolation
CSS Backgrounds and Borders Module Level 3 background-(clip|origin|position|size), border-image
CSS Backgrounds and Borders Module Level 4 background-position-(x|y)
CSS Basic User Interface Module Level 4 outline-style
CSS Box Sizing Module Level 4 aspect-ratio
CSS Containment Module Level 2 contain, content-visibility
CSS Flexible Box Layout Module Level 1 flex-flow
CSS Fonts Module Level 4 font-style
CSS Fragmentation Module Level 3 orphans, widows
CSS Grid Layout Module Level 2 grid, grid-auto-(columns|rows), grid-template
CSS Images Module Level 3 object-position
CSS Inline Layout Module Level 3 initial-letter
CSS Lists and Counters Module Level 3 counter-(increment|reset|set), list-style
CSS Logical Properties and Values Level 1 border-(block|inline)(-(end|start))?(-(color|width))?
CSS Masking Module Level 1 mask-(position|size)
CSS Mobile Text Size Adjustment Module Level 1 text-size-adjust
CSS Overflow Module Level 3 scroll-behavior
CSS Ruby Annotation Layout Module Level 1 ruby-(align|merge)
CSS Scrollbars Styling Module Level 1 scrollbar-(color|width)
CSS Text Module Level 4 hyphenate-limit-chars
CSS Transitions transition(-(delay|duration|property|timing-function))?
CSS Will Change Module Level 1 will-change
CSS Writing Modes Level 4 direction, text-orientation, unicode-bidi, writing-mode

Related issues and pull requests

Fixes #584.

Note: This PR doesn't address the infra problem in the issue above.

@yarusome yarusome marked this pull request as draft April 13, 2023 04:09
@yarusome yarusome marked this pull request as ready for review April 13, 2023 05:10
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit ed21786 into mdn:main Apr 13, 2023
@yarusome yarusome deleted the discrete branch April 13, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants