Add computed table to padding-block/padding-inline #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #477
Updates the padding-block and padding-inline properties to be marked as shorthands with the computed table. The spec lists them as shorthands for -start and -end so I felt it makes sense to put that in the table here.
This helps fix frenic/csstype#93 and I hoped to reopen discussion since the issues haven't been worked on for a year. Microsoft's CSS-in-JS library (and other CSS libraries) need shorthands to be clearly marked to avoid issues.
If this computed table is inaccurate I'd like to explore other alternatives. If it is, I can update other logical shorthand properties to match.