Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add justify-items CSS property #185

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Add justify-items CSS property #185

merged 3 commits into from
Apr 4, 2018

Conversation

pkuczynski
Copy link
Contributor

@pkuczynski pkuczynski commented Feb 28, 2018 •
edited
Loading

@lahmatiy
Copy link
Contributor

Looks like CSS Box Alignment Module is a new group. It should be renamed to CSS Box Alignment and added to css/definitions.json

@pkuczynski
Copy link
Contributor Author

Sure! Done...

This was referenced Feb 28, 2018
Merged
Merged
wbamberg
wbamberg requested changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct me if I'm wrong, but it looks like the syntax for this property has changed in the (too long) that this PR has been open.

css/properties.json Outdated
@@ -4667,6 4667,21 @@
"order": "uniqueOrder",
"status": "standard"
},
"justify-items": {
"syntax": "normal | stretch | <baseline-position> | [ <overflow-position>? <self-position> ] | [ legacy || [ left | right | center ] ]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks as if this has changed: https://drafts.csswg.org/css-align-3/#propdef-justify-items. If you agree, and can update it, I'll merge this PR.

@frenic frenic mentioned this pull request Apr 4, 2018
Closed
@pkuczynski
Copy link
Contributor Author

@wbamberg I updated the PR. Is it good now? It's annoying that it's stuck for so long. I was planning to add more stuff, but my PR has not been merged so my motivation floored.

@wbamberg
Copy link
Contributor

wbamberg commented Apr 4, 2018

It's annoying that it's stuck for so long.

I know, I'm sorry about that. Thanks for your contribution. It looks good to me now, and since it already got the 👍 from lahmatiy, let's merge this.

@wbamberg wbamberg merged commit acb3801 into mdn:master Apr 4, 2018
@pkuczynski pkuczynski deleted the justify-items branch April 4, 2018 22:28
@pkuczynski
Copy link
Contributor Author

No worries, we all busy :)

@pkuczynski
Copy link
Contributor Author

So now time for #184 :)

@frenic
Copy link
Contributor

frenic commented Apr 4, 2018

I'm thankful too @pkuczynski for all your PRs. I would love to see more from you 🙏

@pkuczynski
Copy link
Contributor Author

We will see @frenic ;)

This was referenced Apr 5, 2018
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkuczynski @lahmatiy @wbamberg @frenic